[7.4.1] Fix double encoding of inputs in worker request #24123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `WorkRequest` encodes strings as UTF-8, Bazel's internal string encoding of file paths needs to be undone before passing them to the protobuf builder. Closes bazelbuild#23924. PiperOrigin-RevId: 690737819 Change-Id: I3eb341c05e045c75ac004da57e1f46f3587a6810
bazel-io
added
team-Local-Exec
|
@fmeum Can you take a look at the presubmit failrues? |
fmeum
reviewed
Oct 29, 2024
There was a problem hiding this comment.
@meteorcloudy I can't edit directly, so please try these suggested changes.
src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java
Outdated
Show resolved
Hide resolved
…Runner.java Co-authored-by: Fabian Meumertzheim <[email protected]>
…Runner.java Co-authored-by: Fabian Meumertzheim <[email protected]>
meteorcloudy
approved these changes
Oct 29, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
WorkRequestencodes strings as UTF-8, Bazel's internal string encoding of file paths needs to be undone before passing them to the protobuf builder.Closes #23924.
PiperOrigin-RevId: 690737819
Change-Id: I3eb341c05e045c75ac004da57e1f46f3587a6810
Commit 89f798e