Fix double encoding of inputs in worker request #23924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `WorkRequest` encodes strings as UTF-8, Bazel's internal string encoding of file paths needs to be undone before passing them to the protobuf builder.
|
@bazel-io fork 8.0.0 |
github-actions
bot
added
team-Local-Exec
|
@bazel-io fork 7.4.0 |
This was referenced Oct 9, 2024
|
How did this not show up as problematic before? |
The only worker supplied with Bazel (Javac) doesn't read the field. I don't know whether any worker does. Multiplex sandboxing would probably be a better way to do that. |
tjgq
requested changes
Oct 22, 2024
src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java
Outdated
Show resolved
Hide resolved
tjgq
approved these changes
Oct 28, 2024
tjgq
added
awaiting-PR-merge
|
@bazel-io fork 7.4.1 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Oct 28, 2024
Since `WorkRequest` encodes strings as UTF-8, Bazel's internal string encoding of file paths needs to be undone before passing them to the protobuf builder. Closes bazelbuild#23924. PiperOrigin-RevId: 690737819 Change-Id: I3eb341c05e045c75ac004da57e1f46f3587a6810
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Oct 28, 2024
Since `WorkRequest` encodes strings as UTF-8, Bazel's internal string encoding of file paths needs to be undone before passing them to the protobuf builder. Closes bazelbuild#23924. PiperOrigin-RevId: 690737819 Change-Id: I3eb341c05e045c75ac004da57e1f46f3587a6810
iancha1992
pushed a commit
that referenced
this pull request
Oct 29, 2024
Since `WorkRequest` encodes strings as UTF-8, Bazel's internal string encoding of file paths needs to be undone before passing them to the protobuf builder. Closes #23924. PiperOrigin-RevId: 690737819 Change-Id: I3eb341c05e045c75ac004da57e1f46f3587a6810 Commit 89f798e Co-authored-by: Fabian Meumertzheim <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
Since `WorkRequest` encodes strings as UTF-8, Bazel's internal string encoding of file paths needs to be undone before passing them to the protobuf builder. Closes #23924. PiperOrigin-RevId: 690737819 Change-Id: I3eb341c05e045c75ac004da57e1f46f3587a6810 Commit 89f798e Co-authored-by: Fabian Meumertzheim <[email protected]>
|
The changes in this PR have been included in Bazel 7.4.1 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
WorkRequestencodes strings as UTF-8, Bazel's internal string encoding of file paths needs to be undone before passing them to the protobuf builder.