Fix in-process materialization of unresolved symlinks in runfiles #23328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
23327-inprocess-unresolved-symlink
branch
from
ff8c1fe
to
07b5275
Compare
fmeum
force-pushed
the
23327-inprocess-unresolved-symlink
branch
from
07b5275
to
161c61f
Compare
github-actions
bot
added
the
awaiting-review
|
@bazel-io fork 7.4.0 |
iancha1992
added
the
team-Local-Exec
tjgq
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Aug 22, 2024
Unresolved symlinks, when consumed as runfiles with `--experimental_inprocess_symlink_creation`, are now created as symlinks directly pointing to their target path instead of to the absolute path of the unresolved symlink artifact under the execroot, just like with out-of-process symlink creation. Along the way, fix the propagation of `--experimental_inprocess_symlink_creation` to the exec configuration, which previously would have caused the new test cases to fail open. Fixes bazelbuild#23327 Closes bazelbuild#23328. PiperOrigin-RevId: 665754549 Change-Id: I6b240ca27dac513738056b015c97baec91677c4e
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
…iles (#23391) Unresolved symlinks, when consumed as runfiles with `--experimental_inprocess_symlink_creation`, are now created as symlinks directly pointing to their target path instead of to the absolute path of the unresolved symlink artifact under the execroot, just like with out-of-process symlink creation. Along the way, fix the propagation of `--experimental_inprocess_symlink_creation` to the exec configuration, which previously would have caused the new test cases to fail open. Fixes #23327 Closes #23328. PiperOrigin-RevId: 665754549 Change-Id: I6b240ca27dac513738056b015c97baec91677c4e Closes #23329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unresolved symlinks, when consumed as runfiles with
--experimental_inprocess_symlink_creation, are now created as symlinks directly pointing to their target path instead of to the absolute path of the unresolved symlink artifact under the execroot, just like with out-of-process symlink creation.Along the way, fix the propagation of
--experimental_inprocess_symlink_creationto the exec configuration, which previously would have caused the new test cases to fail open.Fixes #23327