Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-process symlink creation doesn't materialize unresolved symlinks as such #23327

Closed
fmeum opened this issue Aug 18, 2024 · 1 comment
Closed

In-process symlink creation doesn't materialize unresolved symlinks as such #23327

fmeum opened this issue Aug 18, 2024 · 1 comment
Assignees
@fmeum
Labels
P1 I'll work on this now. (Assignee required) team-Local-Exec Issues and PRs for the Execution (Local) team type: bug

Comments

@fmeum
Copy link
Collaborator

fmeum commented Aug 18, 2024

I would just like to point out this breaking issue with rules_js that I found when --experimental_inprocess_symlink_creation is turned on in Bazel 7.2.

Unsure if its Bazel, or the rules that aren't vibing with this in the way that is expected, but the rule set is popular enough you may want to see it resolved first.

I suspect I'm the first-mover to come across this.

Here is the ticket: aspect-build/rules_js#1877

Originally posted by @adamscybot in #4327 (comment)
@fmeum fmeum self-assigned this Aug 18, 2024
@fmeum fmeum added P1 I'll work on this now. (Assignee required) type: bug team-Local-Exec Issues and PRs for the Execution (Local) team labels Aug 18, 2024
This was referenced Aug 18, 2024
Closed
Closed
fmeum added a commit to fmeum/bazel that referenced this issue Aug 22, 2024
@fmeum
Fix in-process materialization of unresolved symlinks in runfiles
15a4335 
Unresolved symlinks, when consumed as runfiles with `--experimental_inprocess_symlink_creation`, are now created as symlinks directly pointing to their target path instead of to the absolute path of the unresolved symlink artifact under the execroot, just like with out-of-process symlink creation.

Along the way, fix the propagation of `--experimental_inprocess_symlink_creation` to the exec configuration, which previously would have caused the new test cases to fail open.

Fixes bazelbuild#23327

Closes bazelbuild#23328.

PiperOrigin-RevId: 665754549
Change-Id: I6b240ca27dac513738056b015c97baec91677c4e
@fmeum fmeum mentioned this issue Aug 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 22, 2024
@fmeum
[7.4.0] Fix in-process materialization of unresolved symlinks in runf…
069dd38 
…iles (#23391)

Unresolved symlinks, when consumed as runfiles with
`--experimental_inprocess_symlink_creation`, are now created as symlinks
directly pointing to their target path instead of to the absolute path
of the unresolved symlink artifact under the execroot, just like with
out-of-process symlink creation.

Along the way, fix the propagation of
`--experimental_inprocess_symlink_creation` to the exec configuration,
which previously would have caused the new test cases to fail open.

Fixes #23327

Closes #23328.

PiperOrigin-RevId: 665754549
Change-Id: I6b240ca27dac513738056b015c97baec91677c4e

Closes #23329
@iancha1992
Copy link
Member

A fix for this issue has been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.4.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmeum fmeum

Labels
P1 I'll work on this now. (Assignee required) team-Local-Exec Issues and PRs for the Execution (Local) team type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix in-process materialization of unresolved symlinks in runfiles fmeum/bazel
2 participants
@fmeum @iancha1992