Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TEST_PREMATURE_EXIT_FILE #23284

Closed
wants to merge 2 commits into from
Closed

Implement TEST_PREMATURE_EXIT_FILE #23284

wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Aug 13, 2024

The Bazel test docs claim that a test will fail if a file exists at the path indicated by TEST_PREMATURE_EXIT_FILE, but this has not yet been the case in Bazel.

This feature is used by googletest (https://google.github.io/googletest/advanced.html#detecting-test-premature-exit).

@fmeum
Implement TEST_PREMATURE_EXIT_FILE
11df65e 
The Bazel test docs claim that a test will fail if a file exists at the path indicated by `TEST_PREMATURE_EXIT_FILE`, but this has not yet been the case in Bazel.

This feature is used by `googletest` (https://google.github.io/googletest/advanced.html#detecting-test-premature-exit).
@fmeum fmeum requested a review from a team as a code owner August 13, 2024 11:34
@github-actions github-actions bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Aug 13, 2024
@fmeum fmeum requested review from tjgq and removed request for a team and tjgq August 13, 2024 11:35
@meteorcloudy meteorcloudy requested a review from lberki August 13, 2024 12:00
@fmeum
Copy link
Collaborator Author

fmeum commented Aug 13, 2024 •
edited
Loading

@lberki Is this feature supported by the internal test strategy implementation? Could you also let me know what test.warnings is about?

@tjgq tjgq added team-Core Skyframe, bazel query, BEP, options parsing, bazelrc and removed team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Aug 21, 2024
@fmeum fmeum mentioned this pull request Aug 21, 2024
Closed
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 13, 2024

@lberki Friendly ping

lberki
lberki reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@lberki lberki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, modulo that one comment.

src/test/py/bazel/bazel_windows_test.py Show resolved Hide resolved
@lberki lberki added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 16, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 17, 2024
@fmeum fmeum deleted the test_premature_exit_file branch September 17, 2024 18:07
@cushon cushon mentioned this pull request Nov 16, 2024
Open
@meteorcloudy meteorcloudy mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lberki lberki lberki approved these changes

Assignees
No one assigned
Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmeum @lberki @tjgq