Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.1.0] Move compile StarlarkMethod back to CcModuleAPI #21590

Closed

Conversation

bazel-io
Copy link
Member

@bazel-io bazel-io commented Mar 6, 2024

This way the documentation is again generated.
Fixes: #20922
Commit a4febaa

PiperOrigin-RevId: 612810046
Change-Id: I38f3ab01d1f4951eeb9045bbf214057824be6fd4

This way the documentation is again generated.
Fixes: bazelbuild#20922
PiperOrigin-RevId: 612810046
Change-Id: I38f3ab01d1f4951eeb9045bbf214057824be6fd4
@bazel-io bazel-io requested a review from a team as a code owner March 6, 2024 07:42
@bazel-io bazel-io added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Mar 6, 2024
@bazel-io bazel-io requested a review from comius March 6, 2024 07:42
@iancha1992 iancha1992 enabled auto-merge March 6, 2024 07:43
@meteorcloudy
Copy link
Member

src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/CcModuleApi.java:383: error: could not resolve Info
      Info starlarkCcToolchainProvider,
      ^

@comius Can you address the presubmit failure?

@keertk
Copy link
Member

keertk commented Mar 7, 2024

Friendly ping. We're hoping to create rc2 today. Do we want to wait for this one?

@keertk
Copy link
Member

keertk commented Mar 7, 2024

Closing this in favour of #21605.

@keertk keertk closed this Mar 7, 2024
auto-merge was automatically disabled March 7, 2024 14:58

Pull request was closed

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants