Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.1.0] Move compile StarlarkMethod back to CcModuleAPI #21589

Closed
iancha1992 opened this issue Mar 6, 2024 · 3 comments
Closed

[7.1.0] Move compile StarlarkMethod back to CcModuleAPI #21589

iancha1992 opened this issue Mar 6, 2024 · 3 comments
Milestone
7.1.0 release blo...

Comments

@iancha1992
Copy link
Member

Commit IDs

a4febaa

Category

team-Rules-CPP

Reviewers

@comius
@iancha1992 iancha1992 added this to the 7.1.0 release blockers milestone Mar 6, 2024
@bazel-io
Copy link
Member

bazel-io commented Mar 6, 2024

The following commits were cherry-picked in #21590: a4febaa.

iancha1992 referenced this issue Mar 6, 2024
@comius @copybara-github
Move compile StarlarkMethod back to CcModuleAPI
a4febaa 
This way the documentation is again generated.
Fixes: #20922
PiperOrigin-RevId: 612810046
Change-Id: I38f3ab01d1f4951eeb9045bbf214057824be6fd4
@iancha1992
Copy link
Member Author

cc: @fmeum

@comius comius mentioned this issue Mar 7, 2024
Merged
@keertk
Copy link
Member

keertk commented Mar 7, 2024

#21605

github-merge-queue bot pushed a commit that referenced this issue Mar 7, 2024
@comius @meteorcloudy
[7.1.0] Move compile StarlarkMethod back to CcModuleAPI (#21605)
2b440b8 
This way the documentation is again generated.
Fixes: #20922,
#21589
Commit
a4febaa

PiperOrigin-RevId: 612810046
Change-Id: I38f3ab01d1f4951eeb9045bbf214057824be6fd4

---------

Co-authored-by: Yun Peng <[email protected]>
@keertk keertk closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1.0 release blockers
Development

No branches or pull requests
3 participants
@bazel-io @keertk @iancha1992