Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make repo marker files sensitive to repo mapping changes #21131

Closed
wants to merge 4 commits into from

Conversation

Wyverald
Copy link
Member

Similar to the fix for #20721, we write recorded repo mapping entries into the marker file so that repo fetching is sensitive to any relevant repo mapping changes.

Fixes #20722.

Similar to the fix for #20721, we write recorded repo mapping entries into the marker file so that repo fetching is sensitive to any relevant repo mapping changes.

Fixes #20722.
@Wyverald Wyverald requested a review from lberki as a code owner January 29, 2024 23:17
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jan 29, 2024
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 30, 2024
@copybara-service copybara-service bot closed this in 9edaddd Feb 1, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 1, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 1, 2024
Similar to the fix for bazelbuild#20721, we write recorded repo mapping entries into the marker file so that repo fetching is sensitive to any relevant repo mapping changes.

Fixes bazelbuild#20722.

Closes bazelbuild#21131.

PiperOrigin-RevId: 603310262
Change-Id: I806f383e8579fed3533fac9b181efd8b75e76fcd
github-merge-queue bot pushed a commit that referenced this pull request Feb 1, 2024
)

Similar to the fix for #20721,
we write recorded repo mapping entries into the marker file so that repo
fetching is sensitive to any relevant repo mapping changes.

Fixes #20722.

Closes #21131.

Commit
9edaddd

PiperOrigin-RevId: 603310262
Change-Id: I806f383e8579fed3533fac9b181efd8b75e76fcd

Co-authored-by: Xdng Yng <[email protected]>
@Wyverald Wyverald deleted the wyv-repo-record-mapping branch February 1, 2024 15:54
copybara-service bot pushed a commit that referenced this pull request Feb 16, 2024
See #21131 (comment)

Closes #21390.

PiperOrigin-RevId: 607821270
Change-Id: I031222ee80c4db4ca50372c549e2b522ac606cb7
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 17, 2024
See bazelbuild#21131 (comment)

Closes bazelbuild#21390.

PiperOrigin-RevId: 607821270
Change-Id: I031222ee80c4db4ca50372c549e2b522ac606cb7
github-merge-queue bot pushed a commit that referenced this pull request Feb 19, 2024
See
#21131 (comment)

Closes #21390.

Commit
38c1d5d

PiperOrigin-RevId: 607821270
Change-Id: I031222ee80c4db4ca50372c549e2b522ac606cb7

Co-authored-by: Xdng Yng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository rules aren't refetched when their repo mappings change
4 participants