-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository rules aren't refetched when their repo mappings change #20722
Comments
@bazel-io fork 7.0.1 |
@Wyverald @meteorcloudy This, combined with f4be0b2#diff-ef4da5cc2da76cded220009a0dcc95373700d704629a1a2e9ebe84a9be076854, actually breaks |
If you don't plan to solve this for 7.0.1, we could alternatively fix the more immediate issue by getting rid of the |
As long as bazelbuild#20722 isn't resolved, the canonical name for the given apparent name can change without the repo rule being refetched.
Feel free to downgrade this to 7.1.0 if you think that #20810 is reasonable in the meantime. |
As long as bazelbuild#20722 isn't resolved, the canonical name for the given apparent name can change without the repo rule being refetched.
As long as bazelbuild#20722 isn't resolved, the canonical name for the given apparent name can change without the repo rule being refetched.
@bazel-io fork 7.1.0 |
As long as bazelbuild#20722 isn't resolved, the canonical name for the given apparent name can change without the repo rule being refetched. Closes bazelbuild#20810. PiperOrigin-RevId: 597048244 Change-Id: I225424cc32e572b26c6d6e76e2c09c4d2e6a4ba6 Closes bazelbuild#20825
As long as bazelbuild#20722 isn't resolved, the canonical name for the given apparent name can change without the repo rule being refetched. Closes bazelbuild#20810. PiperOrigin-RevId: 597048244 Change-Id: I225424cc32e572b26c6d6e76e2c09c4d2e6a4ba6 Closes bazelbuild#20825
As long as #20722 isn't resolved, the canonical name for the given apparent name can change without the repo rule being refetched. Closes #20810. Commit 1c45bc5 PiperOrigin-RevId: 597048244 Change-Id: I225424cc32e572b26c6d6e76e2c09c4d2e6a4ba6 --------- Co-authored-by: Fabian Meumertzheim <[email protected]>
Similar to the fix for bazelbuild#20721, we write recorded repo mapping entries into the marker file so that repo fetching is sensitive to any relevant repo mapping changes. Fixes bazelbuild#20722. Closes bazelbuild#21131. PiperOrigin-RevId: 603310262 Change-Id: I806f383e8579fed3533fac9b181efd8b75e76fcd
) Similar to the fix for #20721, we write recorded repo mapping entries into the marker file so that repo fetching is sensitive to any relevant repo mapping changes. Fixes #20722. Closes #21131. Commit 9edaddd PiperOrigin-RevId: 603310262 Change-Id: I806f383e8579fed3533fac9b181efd8b75e76fcd Co-authored-by: Xdng Yng <[email protected]>
A fix for this issue has been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. Thanks! |
Description of the bug:
This is similar to #20721, but 1) about repository rules rather than module extensions and 2) not a regression in 7.0.0.
A repository rule isn't refetched when its repo mapping changes, which can result in
Label(...)
calls made in the implementation function to return stale results when canonical repo names change, e.g. duringbazel_dep
version bumps.Which category does this issue belong to?
External Dependency
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Which operating system are you running Bazel on?
No response
What is the output of
bazel info release
?7.0.0 and HEAD
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse master; git rev-parse HEAD
?No response
Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.
No response
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response
The text was updated successfully, but these errors were encountered: