Fix vs autodetection #18945
Closed
Fix vs autodetection #18945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
Windows VS 2022 version 17.6 introduced a new `vspkg` directory underneath `VC` that is throwing off the toolchain autodetection code. The checks now got renamed to a more approriate `_is_vs_2017_or_newer` and takes into account the possible presence of this `vspkg` directory.
|
@bazel-io fork 6.3.0 |
meteorcloudy
requested changes
Jul 17, 2023
|
|
||
| # The layout of VC folder in VS 2017 and 2019 is different from that in VS 2015 and older versions. | ||
| # In VS 2017 and 2019, it contains only three directories: | ||
| # The layout of VC folder in VS 2017 and newer versions is different from that in VS 2015 and older versions. |
There was a problem hiding this comment.
Can you update the comment here as well?
There was a problem hiding this comment.
Maybe just:
# For VS 2017 and later, a `Tools` directory should exist under BAZEL_VC
There was a problem hiding this comment.
I can also do this while importing the PR!
|
Reading through the smaller commits in this PR (the first one was very similar to mine in #18847), I'm stoked to find others who care about Bazel support for Windows 🤗 Thanks for contributing! |
github-actions
bot
removed
the
awaiting-review
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jul 17, 2023
This is the same PR as bazelbuild#18608 but extended by the modification proposed by @meteorcloudy This should fix bazelbuild#18592 Should also be picked to 6.3.0 -> bazelbuild#18799 Closes bazelbuild#18945. PiperOrigin-RevId: 548725707 Change-Id: Iff0f972c9fc23491c8070ee2b12ec600a3d1ead9
iancha1992
added a commit
that referenced
this pull request
Jul 19, 2023
This is the same PR as #18608 but extended by the modification proposed by @meteorcloudy This should fix #18592 Should also be picked to 6.3.0 -> #18799 Closes #18945. PiperOrigin-RevId: 548725707 Change-Id: Iff0f972c9fc23491c8070ee2b12ec600a3d1ead9 Co-authored-by: Vertexwahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR as #18608 but extended by the modification proposed by @meteorcloudy
This should fix #18592
Should also be picked to 6.3.0 -> #18799