windows_cc_configure: support Visual Studio 2022 #18847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Visual Studio 2022, `vcpkg` folder was added to the content (1). Refactor the logic that check for VS 2017 and 2019 to supporting all versions equal or above 2017, as long as the contents statisfy. (1): https://devblogs.microsoft.com/cppblog/vcpkg-is-now-included-with-visual-studio/
github-actions
bot
added
awaiting-review
|
cc: @meteorcloudy @mai93 I think you guys are familiar with this file? |
|
ci seems flaky and failure seems unrelated 🤔 |
|
#18945 is trying to address the same issue and is a bit simpler, so let's get that one in 6.3.0! |
github-actions
bot
removed
the
awaiting-review
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Visual Studio 2022,
vcpkgfolder was added to the content (1).Refactor the logic that check for VS 2017 and 2019 to supporting all
versions equal or above 2017, as long as the contents statisfy.
(1): https://devblogs.microsoft.com/cppblog/vcpkg-is-now-included-with-visual-studio/