Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --experimental_remote_build_event_upload to --remote_build_event_upload #17972

Closed
wants to merge 1 commit into from
Closed

Rename --experimental_remote_build_event_upload to --remote_build_event_upload #17972

wants to merge 1 commit into from

Conversation

brentleyjones
Copy link
Contributor

RELNOTES: --experimental_remote_build_event_upload has been renamed to --remote_build_event_upload

@brentleyjones
Rename --experimental_remote_build_event_upload to `--remote_build_…
7f37621 
…event_upload`

RELNOTES: `--experimental_remote_build_event_upload` has been renamed to `--remote_build_event_upload`
@brentleyjones brentleyjones requested a review from a team as a code owner April 4, 2023 13:14
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Apr 4, 2023
@brentleyjones brentleyjones mentioned this pull request Apr 4, 2023
Closed
@meteorcloudy meteorcloudy requested a review from coeuvre April 4, 2023 13:20
@brentleyjones
Copy link
Contributor Author

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 4, 2023
@meteorcloudy
Copy link
Member

@bazel-io fork 6.2.0

@bazel-io bazel-io mentioned this pull request Apr 4, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 4, 2023
@coeuvre
Copy link
Member

coeuvre commented Apr 4, 2023

I would rather NOT cherry-pick this change to 6.x so we still have the chance to make changes if needed.

@brentleyjones
Copy link
Contributor Author

Works for me, I closed that issue.

@brentleyjones
Copy link
Contributor Author

brentleyjones commented Apr 4, 2023 •
edited
Loading

Can this get the awaiting-PR-merge label?

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 4, 2023
@copybara-service copybara-service bot closed this in fb16e8c Apr 5, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 5, 2023
@brentleyjones brentleyjones deleted the bj/remame-experimental_remote_build_event_upload-to-remote_build_event_upload branch April 5, 2023 13:51
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@brentleyjones @fweikert
Rename --experimental_remote_build_event_upload to `--remote_build_…
1c5a786 
…event_upload`

RELNOTES: `--experimental_remote_build_event_upload` has been renamed to `--remote_build_event_upload`

Closes bazelbuild#17972.

PiperOrigin-RevId: 521990953
Change-Id: I6e47ac6ae7e52c3fd73694ecff8df71b5b088b9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brentleyjones @meteorcloudy @coeuvre @bazel-io @sgowroji