Skip to content

Commit

Permalink
Rename --experimental_remote_build_event_upload to `--remote_build_…
Browse files Browse the repository at this point in the history
…event_upload`

RELNOTES: `--experimental_remote_build_event_upload` has been renamed to `--remote_build_event_upload`

Closes #17972.

PiperOrigin-RevId: 521990953
Change-Id: I6e47ac6ae7e52c3fd73694ecff8df71b5b088b9c
  • Loading branch information
brentleyjones authored and copybara-github committed Apr 5, 2023
1 parent cccd57e commit fb16e8c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -265,14 +265,15 @@ public final class RemoteOptions extends CommonRemoteOptions {
effectTags = {OptionEffectTag.UNKNOWN},
deprecationWarning =
"--incompatible_remote_build_event_upload_respect_no_cache has been deprecated in favor"
+ " of --experimental_remote_build_event_upload=minimal.",
+ " of --remote_build_event_upload=minimal.",
help =
"If set to true, outputs referenced by BEP are not uploaded to remote cache if the"
+ " generating action cannot be cached remotely.")
public boolean incompatibleRemoteBuildEventUploadRespectNoCache;

@Option(
name = "experimental_remote_build_event_upload",
name = "remote_build_event_upload",
oldName = "experimental_remote_build_event_upload",
defaultValue = "all",
documentationCategory = OptionDocumentationCategory.REMOTE,
effectTags = {OptionEffectTag.UNKNOWN},
Expand Down
18 changes: 9 additions & 9 deletions src/test/shell/bazel/remote/remote_build_event_uploader_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ EOF

bazel build \
--remote_executor=grpc://localhost:${worker_port} \
--experimental_remote_build_event_upload=minimal \
--remote_build_event_upload=minimal \
--build_event_json_file=$BEP_JSON \
//a:foo >& $TEST_log || fail "Failed to build"

Expand All @@ -130,7 +130,7 @@ EOF

bazel build \
--remote_executor=grpc://localhost:${worker_port} \
--experimental_remote_build_event_upload=minimal \
--remote_build_event_upload=minimal \
--build_event_json_file=$BEP_JSON \
//a:foo >& $TEST_log || fail "Failed to build"

Expand All @@ -151,7 +151,7 @@ EOF
bazel build \
--remote_cache=grpc://localhost:${worker_port} \
--remote_upload_local_results=false \
--experimental_remote_build_event_upload=minimal \
--remote_build_event_upload=minimal \
--build_event_json_file=$BEP_JSON \
//a:foo >& $TEST_log || fail "Failed to build"

Expand All @@ -176,7 +176,7 @@ EOF
--disk_cache=$cache_dir \
--incompatible_remote_results_ignore_disk \
--remote_upload_local_results=false \
--experimental_remote_build_event_upload=minimal \
--remote_build_event_upload=minimal \
--build_event_json_file=$BEP_JSON \
//a:foo >& $TEST_log || fail "Failed to build"

Expand Down Expand Up @@ -208,7 +208,7 @@ EOF

bazel build \
--remote_executor=grpc://localhost:${worker_port} \
--experimental_remote_build_event_upload=minimal \
--remote_build_event_upload=minimal \
--build_event_json_file=$BEP_JSON \
//a:foo-alias >& $TEST_log || fail "Failed to build"

Expand Down Expand Up @@ -254,7 +254,7 @@ EOF

bazel build \
--remote_executor=grpc://localhost:${worker_port} \
--experimental_remote_build_event_upload=minimal \
--remote_build_event_upload=minimal \
--build_event_json_file=$BEP_JSON \
//a:foo >& $TEST_log || fail "Failed to build"

Expand All @@ -280,7 +280,7 @@ EOF

bazel test \
--remote_executor=grpc://localhost:${worker_port} \
--experimental_remote_build_event_upload=minimal \
--remote_build_event_upload=minimal \
--build_event_json_file=$BEP_JSON \
//a:test >& $TEST_log || fail "Failed to build"

Expand All @@ -303,7 +303,7 @@ EOF

bazel build \
--remote_executor=grpc://localhost:${worker_port} \
--experimental_remote_build_event_upload=minimal \
--remote_build_event_upload=minimal \
--build_event_json_file=$BEP_JSON \
//a:foo >& $TEST_log || true

Expand All @@ -324,7 +324,7 @@ EOF

bazel build \
--remote_executor=grpc://localhost:${worker_port} \
--experimental_remote_build_event_upload=minimal \
--remote_build_event_upload=minimal \
--profile=mycommand.profile.gz \
--build_event_json_file=$BEP_JSON \
//a:foo >& $TEST_log || fail "Failed to build"
Expand Down

0 comments on commit fb16e8c

Please sign in to comment.