Force the Bazel server Java runtime to use the root locale #17702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures consistent behavior of string operations even if the individual operations do not set a locale. Without this change, Bazel can't operate in e.g. a Turkish locale, where it fails with error messages such as: In rule 'test', size 'medium' is not a valid size. This is because Turkish case mapping rules make it so that a capital ASCII 'I' lowercases to a non-ASCII variant of 'i'.
sgowroji
added
team-Rules-CPP
meteorcloudy
approved these changes
Mar 9, 2023
|
Do we still want #17687 for clarity even though we now have this PR? |
|
My feeling is #17687 is no longer necessary unless we want to enable the error prone check (which is not available yet)? |
|
Yeah, I think I prefer this over #17687 . Less opportunity for things to go wrong. |
lberki
approved these changes
Mar 9, 2023
This was referenced Mar 9, 2023
|
Do you think that this is cherry-pickable? I would have been more comfortable suggesting that with the previous approach, but I also don't see why it shouldn't be safe with this one. |
|
On balance, I think the fact that |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
meteorcloudy
added
awaiting-PR-merge
|
@bazel-io fork 6.2.0 |
bazel-io
removed
the
potential release blocker
sgowroji
removed
the
awaiting-PR-merge
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Mar 10, 2023
This ensures consistent behavior of string operations even if the individual operations do not set a locale. Without this change, Bazel can't operate in e.g. a Turkish locale, where it fails with error messages such as: In rule 'test', size 'medium' is not a valid size. This is because Turkish case mapping rules make it so that a capital ASCII 'I' lowercases to a non-ASCII variant of 'i'. Fixes bazelbuild#17541 Closes bazelbuild#17702. PiperOrigin-RevId: 515339563 Change-Id: I8417d0befd76ba6d140588be5f7e50529af3f6c7
meteorcloudy
pushed a commit
that referenced
this pull request
Mar 13, 2023
This ensures consistent behavior of string operations even if the individual operations do not set a locale. Without this change, Bazel can't operate in e.g. a Turkish locale, where it fails with error messages such as: In rule 'test', size 'medium' is not a valid size. This is because Turkish case mapping rules make it so that a capital ASCII 'I' lowercases to a non-ASCII variant of 'i'. Fixes #17541 Closes #17702. PiperOrigin-RevId: 515339563 Change-Id: I8417d0befd76ba6d140588be5f7e50529af3f6c7 Co-authored-by: Fabian Meumertzheim <[email protected]>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
This ensures consistent behavior of string operations even if the individual operations do not set a locale. Without this change, Bazel can't operate in e.g. a Turkish locale, where it fails with error messages such as: In rule 'test', size 'medium' is not a valid size. This is because Turkish case mapping rules make it so that a capital ASCII 'I' lowercases to a non-ASCII variant of 'i'. Fixes bazelbuild#17541 Closes bazelbuild#17702. PiperOrigin-RevId: 515339563 Change-Id: I8417d0befd76ba6d140588be5f7e50529af3f6c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures consistent behavior of string operations even if the individual operations do not set a locale.
Without this change, Bazel can't operate in e.g. a Turkish locale, where it fails with error messages such as:
In rule 'test', size 'medium' is not a valid size.
This is because Turkish case mapping rules make it so that a capital ASCII 'I' lowercases to a non-ASCII variant of 'i'.
Fixes #17541