Add required --add-opens server JVM args also with non-embedded JDK
#16787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Bazel server requires JDK 11 or higher to run, the `--add-opens` server JVM arg for `java.lang` can now be added unconditionally, which ensures support with JDK 17+. Also removes the additional opens for `java.nio`, which was only needed to silence a protobuf warning that has since been fixed upstream. Fixes bazelbuild#16705 Fixes bazelbuild#15831 Closes bazelbuild#16706. PiperOrigin-RevId: 489372772 Change-Id: I880e2689f59b2d4420b1e2e0517697d7fb03abbc
meteorcloudy
approved these changes
Nov 18, 2022
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Bazel server requires JDK 11 or higher to run, the
--add-opensserver JVM arg forjava.langcan now be added unconditionally, which ensures support with JDK 17+.Also removes the additional opens for
java.nio, which was only needed to silence a protobuf warning that has since been fixed upstream.Fixes #16705
Fixes #15831
Closes #16706.
PiperOrigin-RevId: 489372772
Change-Id: I880e2689f59b2d4420b1e2e0517697d7fb03abbc