Add required --add-opens server JVM args also with non-embedded JDK
#16706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cushon Could you take a look? This seems too simple of a fix, so I may be missing something. |
sgowroji
added
team-Rules-Java
cushon
requested changes
Nov 9, 2022
Makes sense to me: I think this was a workaround for not having a better way to tell if the server javabase was JDK > 8, and now that we don't need JDK 8 passing the flags unconditionally SGTM. |
Since the Bazel server requires JDK 11 or higher to run, the `--add-opens` server JVM arg for `java.lang` can now be added unconditionally, which ensures support with JDK 17+. Also removes the additional opens for `java.nio`, which was only needed to silence a protobuf warning that has since been fixed upstream.
fmeum
force-pushed
the
16705-embedded-opens
branch
from
bec40e7 to
8817436
Compare
cushon
approved these changes
Nov 9, 2022
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@cushon Friendly ping, is this in the process of being merged? |
cushon
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 18, 2022
Since the Bazel server requires JDK 11 or higher to run, the `--add-opens` server JVM arg for `java.lang` can now be added unconditionally, which ensures support with JDK 17+. Also removes the additional opens for `java.nio`, which was only needed to silence a protobuf warning that has since been fixed upstream. Fixes bazelbuild#16705 Fixes bazelbuild#15831 Closes bazelbuild#16706. PiperOrigin-RevId: 489372772 Change-Id: I880e2689f59b2d4420b1e2e0517697d7fb03abbc
meteorcloudy
pushed a commit
that referenced
this pull request
Nov 18, 2022
…#16787) Since the Bazel server requires JDK 11 or higher to run, the `--add-opens` server JVM arg for `java.lang` can now be added unconditionally, which ensures support with JDK 17+. Also removes the additional opens for `java.nio`, which was only needed to silence a protobuf warning that has since been fixed upstream. Fixes #16705 Fixes #15831 Closes #16706. PiperOrigin-RevId: 489372772 Change-Id: I880e2689f59b2d4420b1e2e0517697d7fb03abbc
meteorcloudy
removed
the
potential release blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Bazel server requires JDK 11 or higher to run, the
--add-opensserver JVM arg forjava.langcan now be added unconditionally, which ensures support with JDK 17+.Also removes the additional opens for
java.nio, which was only needed to silence a protobuf warning that has since been fixed upstream.Fixes #16705
Fixes #15831