Hardcode path to dirname on macOS #10222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that some repos have customized PATH so this isn't available. This should fix that.
|
cc @philwo can we run that failed test with this change? I don't really see how this is possible still since if users removed |
|
@keith It looks like the failures are specific to rules_rust, which is running commands under |
|
So they run with no |
philwo
approved these changes
Nov 13, 2019
|
I'm also surprised that this works at all. 🤷♂ Let's merge this. |
|
@philwo should we cherry pick this to fix the downstream tests in the rc? |
|
@keith Yes, I will cherry-pick this into 1.2.0rc2. |
|
Thanks @philwo |
philwo
pushed a commit
that referenced
this pull request
Nov 14, 2019
It seems that some repos have customized PATH so this isn't available. This should fix that. Closes #10222. PiperOrigin-RevId: 280180002
|
FWIW, |
|
Let me know if you see issues with that and this change, it should be ok now |
philwo
pushed a commit
that referenced
this pull request
Nov 20, 2019
It seems that some repos have customized PATH so this isn't available. This should fix that. Closes #10222. PiperOrigin-RevId: 280180002
philwo
pushed a commit
that referenced
this pull request
Nov 25, 2019
It seems that some repos have customized PATH so this isn't available. This should fix that. Closes #10222. PiperOrigin-RevId: 280180002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some repos have customized PATH so this isn't available.
This should fix that.