Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2 - November 2019 (stable) #9983

Closed
dslomov opened this issue Oct 10, 2019 · 27 comments
Closed

Release 1.2 - November 2019 (stable) #9983

dslomov opened this issue Oct 10, 2019 · 27 comments
Assignees
Labels

Comments

@dslomov
Copy link
Contributor

dslomov commented Oct 10, 2019

Target RC: November 4th, 2019

@philwo philwo self-assigned this Oct 11, 2019
@meisterT meisterT pinned this issue Nov 6, 2019
@meisterT
Copy link
Member

meisterT commented Nov 7, 2019

If you didn't cut a baseline yet, you might want to wait until #10184 is merged.

@philwo
Copy link
Member

philwo commented Nov 12, 2019

Status of Bazel 1.2

Bazel 1.2, November 12th and a green downstream pipeline: The stars have finally aligned. Let's get this release ready:

To report a release-blocking bug, please file a bug using the Release blocker label, and cc me.

Task list:

  • Update GitHub issues for incompatible changes
  • Pick release baseline: 11deef7
  • Create release candidate:
  • Check downstream projects:
  • Create draft release announcement
  • Send for review the release announcement PR:
  • Push the release, notify package maintainers:
  • Update the documentation
  • Push the blog post
  • Update the release page

@philwo
Copy link
Member

philwo commented Nov 12, 2019

Created 1.2.0rc1 with baseline 11deef7 and cherry-pick c76c3e5.

RELEASE_NUMBER=1.2.0
BASELINE_COMMIT=11deef7582dfeec7a04ee3f7236393d9b8027367
git clone https://github.com/bazelbuild/bazel.git ~/src/bazel-release-$RELEASE_NUMBER
cd ~/src/bazel-release-$RELEASE_NUMBER
scripts/release/release.sh create $RELEASE_NUMBER $BASELINE_COMMIT c76c3e539c73ecf6e96e3e098be7be59e17bf276
scripts/release/release.sh push

@jmillikin-stripe
Copy link
Contributor

Any chance of getting #10110 in? It's a three-line delta that materially improves ergonomics for scripting languages (Javascript, Ruby) when using hermetic runtimes.

@philwo
Copy link
Member

philwo commented Nov 13, 2019

Will create rc2 with additional cherry-pick #10222 in order to fix broken C++ compilation when using an empty PATH.

@philwo
Copy link
Member

philwo commented Nov 13, 2019

@jmillikin-stripe I reached out to Lukacs, if we can get this reviewed & imported today, I can cherry-pick it.

@jmillikin
Copy link
Contributor

@philwo Thanks a ton! I'll keep an eye on my inbox in case there's any review feedback.

@philwo
Copy link
Member

philwo commented Nov 15, 2019

Bazel 1.2.0rc2 is ready:

RELEASE_NUMBER=1.2.0
RC_NUMBER=2
BASELINE_COMMIT=11deef7582dfeec7a04ee3f7236393d9b8027367
cd ~/src/bazel-release-$RELEASE_NUMBER
scripts/release/release.sh create --force_rc=$RC_NUMBER $RELEASE_NUMBER \
    $BASELINE_COMMIT \
    c76c3e539c73ecf6e96e3e098be7be59e17bf276 \
    63332eb556fadfe9edd0806add79942482adddef \
    ceadf0a063cb97c32aced143d2447781d1dafc38
scripts/release/release.sh push

@johnplate
Copy link

Is it still possible to get #10216 into 1.2? It is a trivial fix for a syntax error occurring with mingw-gcc that prevents us (GAPID team) to upgrade to anything newer than 0.26.0. Thanks in advance!

@keith
Copy link
Member

keith commented Nov 20, 2019

Is there a target date for when this release will be finalized?

@philwo
Copy link
Member

philwo commented Nov 20, 2019

@johnplate I'll get that in.

@keith I hope we can release it tomorrow. I'm not aware of any regressions or other cherry-pick requests. Will do another downstream pipeline run to ensure everything looks green on CI.

@philwo
Copy link
Member

philwo commented Nov 20, 2019

Created Bazel 1.2.0rc3 with:

RELEASE_NUMBER=1.2.0
RC_NUMBER=3
BASELINE_COMMIT=11deef7582dfeec7a04ee3f7236393d9b8027367
cd ~/src/bazel-release-$RELEASE_NUMBER
scripts/release/release.sh create --force_rc=$RC_NUMBER $RELEASE_NUMBER \
    $BASELINE_COMMIT \
    c76c3e539c73ecf6e96e3e098be7be59e17bf276 \
    63332eb556fadfe9edd0806add79942482adddef \
    ceadf0a063cb97c32aced143d2447781d1dafc38 \
    dbe63b00954a25fa4405f7cbf273df78c16498dd
scripts/release/release.sh push

@philwo
Copy link
Member

philwo commented Nov 20, 2019

Downstream is green except for TensorFlow failing on macOS, which seems to be an incompatibility with their protobuf version and Xcode 11.1: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1287

@davido
Copy link
Contributor

davido commented Nov 20, 2019

Am I correct to assume, that the new 1.2 release is the solution for this 1.0.1 overwrites 1.1.0 metadaten in Bazel apt repository issue?

Can we publish 1.2 release ASAP then?

We have complaints from Gerrit users who depend on Bazel apt repository containing the version included in Gerrit's .bazelversion file. They are not able to install 1.1.0, and as the consequence they cannot install the right Bazel version and cannot build gerrit, because the minimum version check is failing.

They cannot install bazelisk because it is not available on their standard Linux distribution.

IOW Gerrit users are blocked and cannot work on gerrit any more.

Here is the request to downgrade Bazel from 1.1.0 to 1.0.1, but that would be a pain, because we would have to revert a number of other changes as well, e.g. related to this Bazel bug.

@philwo
Copy link
Member

philwo commented Nov 20, 2019

@davido Yes, releasing Bazel 1.2.0 will fix the metadata issue for now. I'll do some final checks now and if everything looks fine, I'll release it.

We're very close to fixing the metadata generation for the repository, too, so that it will not happen again in the future.

@philwo
Copy link
Member

philwo commented Nov 20, 2019

Draft blog post with release notes is here: bazelbuild/bazel-blog#209

@philwo
Copy link
Member

philwo commented Nov 20, 2019

Release pushed and now building on CI: https://buildkite.com/bazel-trusted/bazel-release/builds/116

@keith
Copy link
Member

keith commented Nov 20, 2019

@philwo it looks like the public doesn't have access to the pipeline, is there a way it could be readonly publicly?

@philwo
Copy link
Member

philwo commented Nov 20, 2019

@keith I'll see what I can do there tomorrow. 😊

If you're curious, the pipeline definition is here: https://github.com/bazelbuild/continuous-integration/blob/master/pipelines/bazel-release.yml

@philwo
Copy link
Member

philwo commented Nov 21, 2019

Bazel 1.2.0 has been released.

@philwo philwo closed this as completed Nov 21, 2019
@chenrui333
Copy link
Contributor

I have submit a ticket on this, #10297

It seems currently it impacts highsierra users.

@philwo
Copy link
Member

philwo commented Nov 22, 2019

The breakage reported by @chenrui333 will require a patch release, as breaking backwards compatibility with macOS High Sierra was not intended (and is not OK) in the 1.x line.

I'll do that on Monday.

@philwo
Copy link
Member

philwo commented Nov 25, 2019

When bazelbuild/continuous-integration#873 is merged, I will create the patch release.

@philwo
Copy link
Member

philwo commented Nov 26, 2019

Bazel 1.2.1 has been released.

@petemounce
Copy link
Contributor

Chocolatey for 1.2.0 is published, apologies for the wait.

@petemounce
Copy link
Contributor

1.2.1 pushed too.

@philwo
Copy link
Member

philwo commented Nov 28, 2019

Thank you, @petemounce!

@jin jin unpinned this issue Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants