-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runfiles,Python: move to //tools/python/runfiles #4878
Labels
P3
We're not considering working on this, but happy to review a PR. (No assignee)
Comments
laszlocsomor
changed the title
runfiles,Python: move the python runfiles library to @bazel_tools//tools/python/runfiles
runfiles,Python: move to //tools/python/runfiles
Mar 20, 2018
laszlocsomor
added a commit
to laszlocsomor/bazel
that referenced
this issue
Mar 20, 2018
Temporarily remove the Python runfiles library from @bazel_tools and so prevent releasing it in Bazel 0.12.0. Motivation: bazelbuild#4878 Fixing that bug *after* the python library is in release Bazel would be harder because users would need to update their code and BUILD files. Fixing that bug before the library is released is a lot easier because nobody depends on it yet, and we can release the library when it's in the right place. Change-Id: I8adc219410571f9e2a4c8060f5b3239b957fbd5f
laszlocsomor
added
P1
I'll work on this now. (Assignee required)
release blocker
labels
Mar 20, 2018
Blocking #4582 |
bazel-io
pushed a commit
that referenced
this issue
Mar 20, 2018
Temporarily remove the Python runfiles library from @bazel_tools and so prevent releasing it in Bazel 0.12.0. Motivation: #4878 Fixing that bug *after* the python library is in release Bazel would be harder because users would need to update their code and BUILD files. Fixing that bug before the library is released is a lot easier because nobody depends on it yet, and we can release the library when it's in the right place. Closes #4879. Change-Id: I8adc219410571f9e2a4c8060f5b3239b957fbd5f PiperOrigin-RevId: 189744985
philwo
pushed a commit
that referenced
this issue
Mar 21, 2018
Temporarily remove the Python runfiles library from @bazel_tools and so prevent releasing it in Bazel 0.12.0. Motivation: #4878 Fixing that bug *after* the python library is in release Bazel would be harder because users would need to update their code and BUILD files. Fixing that bug before the library is released is a lot easier because nobody depends on it yet, and we can release the library when it's in the right place. Closes #4879. Change-Id: I8adc219410571f9e2a4c8060f5b3239b957fbd5f PiperOrigin-RevId: 189744985
Can we close this issue or is it still a release blocker for 0.12.0? |
It's no longer a blocker, but it's also not resolved. |
laszlocsomor
added
P3
We're not considering working on this, but happy to review a PR. (No assignee)
and removed
P1
I'll work on this now. (Assignee required)
release blocker
labels
Mar 28, 2018
laszlocsomor
added a commit
to laszlocsomor/bazel
that referenced
this issue
Apr 9, 2018
Move the Python runfiles library from @bazel_tools//tools/runfiles:py-runfiles to @bazel_tools//tools/python/runfiles:runfiles Fixes bazelbuild#4878 Change-Id: I874b230c93679d4454ac91e816932c8272ecc5c7
philwo
pushed a commit
that referenced
this issue
Apr 9, 2018
Temporarily remove the Python runfiles library from @bazel_tools and so prevent releasing it in Bazel 0.12.0. Motivation: #4878 Fixing that bug *after* the python library is in release Bazel would be harder because users would need to update their code and BUILD files. Fixing that bug before the library is released is a lot easier because nobody depends on it yet, and we can release the library when it's in the right place. Closes #4879. Change-Id: I8adc219410571f9e2a4c8060f5b3239b957fbd5f PiperOrigin-RevId: 189744985
philwo
pushed a commit
that referenced
this issue
Apr 11, 2018
Temporarily remove the Python runfiles library from @bazel_tools and so prevent releasing it in Bazel 0.12.0. Motivation: #4878 Fixing that bug *after* the python library is in release Bazel would be harder because users would need to update their code and BUILD files. Fixing that bug before the library is released is a lot easier because nobody depends on it yet, and we can release the library when it's in the right place. Closes #4879. Change-Id: I8adc219410571f9e2a4c8060f5b3239b957fbd5f PiperOrigin-RevId: 189744985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the problem / feature request:
The language-specific tools should be under
//tools/<language>/<tool>
but the Python-specific runfiles library is currently under@bazel_tools//tools/runfiles:py-runfiles
(in Bazel 0.12.0 release candidate).See also #4873
The text was updated successfully, but these errors were encountered: