-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release - March 2018 - Target RC date: 2018-03-01 - name: 0.12.0 #4582
Comments
@philwo lmk if you are unavailable on those dates |
@dslomov Should work fine for me :) |
Hey fellows! Do we have an updated date for this RC? |
The current baseline looks pretty good. I'll likely cut an RC today. |
We should investigate whether we should point this out in the release notes, in case others have the same issue: |
This looks like a good baseline to me: b33e5af |
|
Release candidate 1 has been successfully cut, branch has been pushed (https://github.com/bazelbuild/bazel/tree/release-0.12.0) and I managed to convince Buildkite to build our release artifacts with the correctly embedded version number: https://buildkite.com/bazel/release/builds/20 Tomorrow I'll work on the release scripts to finish the Buildkite support and will then do the rest of the release process (verifying produced artifacts, signing, pushing to GCS / APT repository / GitHub and sending the announcement mail). |
This seems like a potential release blocker: #4846 |
#4734 is also a potential blocker, though I doubt it's a regression. |
@philwo : where can we download the RC1 binary? |
Another possible blocker: #4847 |
@laszlocsomor You can download the binaries here: https://buildkite.com/bazel/release/builds/20 (check the "Artifacts" tab for each platform). I'm right now working on getting it out via the usual channels as well. |
I got the release stuff working at last and just sent out the announcement to bazel-discuss@. Binaries are available on our website and via apt-get in the testing branch. Note that I had to rebuild the binaries one more time, because the release notes embedded in the installers were wrong due to an error in the release pipeline script. If you downloaded the binaries from the above Buildkite link, please don't be surprised. There were no functional changes and both the binaries above and the ones in the announcement I just sent out were built from the exact same Git commit. :) |
Please cherry-pick #4866, fixes Android's |
Trying to create 0.12.0rc2 now:
|
Will also cherrypick @meteorcloudy's 0a46220 and 3c5373c |
|
@philwo rc2 will include the junit fix, right? (Meaning you won’t cherry
pick the revert)
…On Wed, 21 Mar 2018 at 17:41 Philipp Wollermann ***@***.***> wrote:
$ scripts/release/release.sh push
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4582 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIFxPlGsUeo2unDtR5YvYZffY-Y2SFks5tgnSsgaJpZM4R5mrb>
.
|
@ittaiz The revert hasn't been cherrypicked, so rc2 should be fine. :) |
Thanks!
…On Wed, 21 Mar 2018 at 18:21 Philipp Wollermann ***@***.***> wrote:
@ittaiz <https://github.com/ittaiz> The revert hasn't been cherrypicked,
so rc2 should be fine. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4582 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIF-vpPDg5_RCHbzX2740Mz1Ss3uIsks5tgn4FgaJpZM4R5mrb>
.
|
0.12.0rc2 pushed: https://releases.bazel.build/0.12.0/rc2/index.html |
Last known release blocker: |
I just noticed this entry in the release notes:
Please remove it, the feature was rolled back in cfe5994. |
FYI, the Bazel release 0.12.0 will be delayed until April 9th due to one remaining release blocker and me being on vacation from tomorrow. I think that's better than rushing it out today only to find out that there's an issue and then I'm not there to fix it :) Bazel 0.12.0rc2 should be pretty much what goes out as final, as I'm not aware of any other known issues, except for the remote caching on Windows issue (#4904). |
Will this mean 0.13.0 will also be delayed?
…On Thu, Mar 29, 2018 at 10:09 AM Philipp Wollermann < ***@***.***> wrote:
FYI, the Bazel release 0.12.0 will be delayed until April 9th due to one
remaining release blocker and me being on vacation from tomorrow. I think
that's better than rushing it out only to find out that there's an issue
and then I'm not there to fix it :)
Bazel 0.12.0rc2 should be pretty much what goes out as final, as I'm not
aware of any other known issues, except for the remote caching on Windows
issue (#4904 <#4904>).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4582 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIFw17rglThhK8a8QYwTH5CBWQQAbWks5tjIibgaJpZM4R5mrb>
.
|
@ittaiz I think we can cut 0.13.0-rc1 as planned. |
0.12.0-rc1 and rc2 have been pushed to chocolatey. |
I'm seeing TF build failure with version >= Bazel 0.12.0rc2 both locally and remotely. Please take a look at tensorflow/tensorflow#17816. |
I'm creating rc3 now with the additional cherrypick f54d7e5 to fix #4904. Thanks @meteorcloudy! |
Bazel 0.12.0rc3 has been pushed. https://groups.google.com/d/msg/bazel-discuss/j7ozGl-I7oE/PsdytIfyBwAJ Tentative release date is Wednesday if we don't find any blockers. |
We have three failures on a full downstream test run (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/193):
Considering that fixes are available upstream and just not merged yet, I don't consider these a blocker. |
Just confirmed with @xingao267 , tensorflow/tensorflow#17816 is also not a regression. |
rc3 is on chocolatey. |
Can we cherry-pick cb16c50 please pretty please ? |
Sure thing, thank you ! |
0.12.0 is up on chocolatey. Apologies for delay! |
Thank you @petemounce :) |
No description provided.
The text was updated successfully, but these errors were encountered: