Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible_genquery_use_graphless_query: Incompatible flag for graphless genquery #12464

Closed
zhengwei143 opened this issue Nov 12, 2020 · 2 comments
Closed

incompatible_genquery_use_graphless_query: Incompatible flag for graphless genquery #12464

zhengwei143 opened this issue Nov 12, 2020 · 2 comments
Assignees
@zhengwei143
Labels
incompatible-change Incompatible/breaking change not stale Issues or PRs that are inactive but not considered stale P2 We'll consider working on this in future. (Assignee optional) team-Performance Issues for Performance teams type: process

Comments

@zhengwei143
Copy link
Contributor

zhengwei143 commented Nov 12, 2020 •
edited
Loading

Flag: --incompatible_genquery_use_graphless_query
Available since: Yet to be released
Will be flipped in: To be confirmed

Motivation

Genquery will now be using graphless query by default since it seems stable enough.

Changes

This changes the default output order of genquery to mainly be in lexicographical order as in graphless query (with the exception of somepath which prints in dependency order - see 93090e1)
@zhengwei143 zhengwei143 added the incompatible-change Incompatible/breaking change label Nov 12, 2020
@zhengwei143 zhengwei143 self-assigned this Nov 12, 2020
@oquenchil oquenchil added team-Performance Issues for Performance teams type: process P2 We'll consider working on this in future. (Assignee optional) labels Nov 16, 2020
@meisterT meisterT added P1 I'll work on this now. (Assignee required) and removed P2 We'll consider working on this in future. (Assignee optional) breaking-change-4.0 labels Nov 18, 2020
@zhengwei143 zhengwei143 added P2 We'll consider working on this in future. (Assignee optional) and removed P1 I'll work on this now. (Assignee required) labels Dec 8, 2020
bazel-io pushed a commit that referenced this issue Mar 2, 2021
@zhengwei143 @copybara-github
Rename and change default experimental_genquery_use_graphless_query.
0f1e303 
Genquery now uses graphless query by default.
This #12464 keeps track of the flag change on github.

PiperOrigin-RevId: 360377997
@meteorcloudy meteorcloudy mentioned this issue Mar 3, 2021
Closed
@meteorcloudy
Copy link
Member

meteorcloudy commented Mar 3, 2021 •
edited
Loading

FYI, the flip of this flag is causing bazel-contrib/rules_jvm_external#529

@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Apr 28, 2023
@meteorcloudy meteorcloudy added not stale Issues or PRs that are inactive but not considered stale and removed stale Issues or PRs that are stale (no activity for 30 days) labels Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhengwei143 zhengwei143

Labels
incompatible-change Incompatible/breaking change not stale Issues or PRs that are inactive but not considered stale P2 We'll consider working on this in future. (Assignee optional) team-Performance Issues for Performance teams type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@meisterT @meteorcloudy @zhengwei143 @oquenchil