Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_jvm_external broken in Bazel downstream due to the flip of --incompatible_genquery_use_graphless_query #529

Closed
meteorcloudy opened this issue Mar 3, 2021 · 4 comments · Fixed by #531

Comments

@meteorcloudy
Copy link
Contributor

meteorcloudy commented Mar 3, 2021

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1939#457fc168-72ac-4485-985e-4c4a1e1919bb

Executing tests from //tests/integration:version_interval_deps_test
-----------------------------------------------------------------------------
1,2c1,4
< @version_interval_testing//:io_grpc_grpc_netty_shaded
< @version_interval_testing//:v1/https/repo1.maven.org/maven2/io/grpc/grpc-netty-shaded/1.29.0/grpc-netty-shaded-1.29.0.jar
---
> @version_interval_testing//:com_google_android_annotations
> @version_interval_testing//:com_google_code_gson_gson
> @version_interval_testing//:com_google_errorprone_error_prone_annotations
> @version_interval_testing//:io_grpc_grpc_api
4c6
< @version_interval_testing//:v1/https/repo1.maven.org/maven2/io/grpc/grpc-core/1.29.0/grpc-core-1.29.0.jar
---
> @version_interval_testing//:io_grpc_grpc_netty_shaded
6,9c8,9
< @version_interval_testing//:io_grpc_grpc_api
< @version_interval_testing//:com_google_errorprone_error_prone_annotations
< @version_interval_testing//:com_google_code_gson_gson
< @version_interval_testing//:com_google_android_annotations
---
> @version_interval_testing//:v1/https/repo1.maven.org/maven2/io/grpc/grpc-core/1.29.0/grpc-core-1.29.0.jar
> @version_interval_testing//:v1/https/repo1.maven.org/maven2/io/grpc/grpc-netty-shaded/1.29.0/grpc-netty-shaded-1.29.0.jar
FAIL: files "tests/integration/version-interval-deps.golden.unix" and "tests/integration/version_interval_deps" differ

https://buildkite.com/bazel/bazel-auto-sheriff-face-with-cowboy-hat/builds/447
Caused by bazelbuild/bazel@0f1e303

Related issue: bazelbuild/bazel#12464

@meteorcloudy
Copy link
Contributor Author

/cc @jin @zhengwei143

@zhengwei143
Copy link

The flip to use graphless query causes the output to be sorted in lexicographical order (from dependency order previously), which is what I assume is causing the issue here when running the diff. Let me look into a quick fix for the test.

@meteorcloudy
Copy link
Contributor Author

Thanks!

@zhengwei143
Copy link

Sent #530 to fix this, should that wait until the flip is released (the tests are failing)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants