Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for make(depset()) from new_sets #68

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

bttk
Copy link
Contributor

@bttk bttk commented Nov 13, 2018

With --incompatible_depset_is_not_iterable depset is no longer
iterable. Remove tests that assumed it is.

Bazel issue:
bazelbuild/bazel#5816

With `--incompatible_depset_is_not_iterable` depset is no longer
iterable. Remove tests that assumed it is.

Bazel issue:
bazelbuild/bazel#5816
@bttk bttk changed the title Remove supports for make(depset()) from new_sets Remove support for make(depset()) from new_sets Nov 14, 2018
@bttk
Copy link
Contributor Author

bttk commented Nov 14, 2018

@laurentlb please take a look

Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@laurentlb laurentlb merged commit db3ce78 into bazelbuild:master Nov 14, 2018
@bttk bttk deleted the no_depset_sets branch November 14, 2018 17:40
@bttk bttk mentioned this pull request Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants