Convert depset into a list before iterating #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change tests pass even if --incompatible_depset_is_not_iterable is used. Bazel issue: bazelbuild/bazel#5816
laurentlb
reviewed
Nov 13, 2018
| @@ -43,6 +43,34 @@ def _precondition_only_sets_or_lists(*args): | |||
| fail("Expected arguments to be depset or list, but found type %s: %r" % | |||
| (t, a)) | |||
|
|
|||
| def _to_set(a): | |||
There was a problem hiding this comment.
cc @c-parsons
I'd prefer to delete this file, rather than maintain it.
There was a problem hiding this comment.
I'd prefer to delete this file, rather than maintain it.
Is there a migration plan for current users? I don't see a deprecation warning in the file.
For example:
- add
print("DEPRECATED: ...at the top ofsets.bzl - Require an action from existing users:
- move
sets.bzlto adeprecatedsubdirectory - rename
sets = struct(tosets_deprecated = struct(
- move
I have tried to use an alias() to add a deprecation warning, but it doesn't seem to be possible.
There was a problem hiding this comment.
The first step will be done with #70
|
Isn't this overlapping with #54 which is waiting on final signoff/changes? |
Waiting for almost 3 weeks now. |
bttk
commented
Nov 14, 2018
| @@ -32,7 +32,7 @@ def _bzl_library_impl(ctx): | |||
| # a separate program, or from `tools` of a genrule(). | |||
| DefaultInfo( | |||
| files = all_files, | |||
| runfiles = ctx.runfiles(files = list(all_files)), | |||
| runfiles = ctx.runfiles(transitive_files = all_files), | |||
There was a problem hiding this comment.
I have moved this change to #69
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change tests pass even if
--incompatible_depset_is_not_iterableis used.Bazel issue:
bazelbuild/bazel#5816