Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Remove the go form of integration testing #170

Merged
merged 1 commit into from
Mar 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
load("@bazel_gazelle//:def.bzl", "gazelle")

package_group(
name = "internal",
packages = ["//..."],
Expand All @@ -15,11 +13,7 @@ filegroup(
name = "all_bzl",
srcs = [
":root_bzl",
"//go:bzl",
"//tools",
],
visibility = ["//:internal"],
)

# gazelle:prefix github.com/bazelbuild/bazel-integration-testing
gazelle(name = "gazelle")
4 changes: 0 additions & 4 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
# Default owner
* @ittaiz
* @achew22

# Java owners
java/* @ittaiz
javatests/* @ittaiz

# Python owners

# Go owners
go/* @jayconrod, @achew22
32 changes: 12 additions & 20 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,25 +49,6 @@ load("@build_bazel_integration_testing//tools:repositories.bzl", "bazel_binaries
#depend on the Bazel binaries, also accepts an array of versions
bazel_binaries()

http_archive(
name = "io_bazel_rules_go",
sha256 = "f04d2373bcaf8aa09bccb08a98a57e721306c8f6043a2a0ee610fd6853dcde3d",
urls = [
"https://github.com/bazelbuild/rules_go/releases/download/0.18.6/rules_go-0.18.6.tar.gz",
],
)

http_archive(
name = "bazel_gazelle",
sha256 = "7fc87f4170011201b1690326e8c16c5d802836e3a0d617d8f75c3af2b23180c4",
urls = [
"https://github.com/bazelbuild/bazel-gazelle/releases/download/0.18.2/bazel-gazelle-0.18.2.tar.gz",
],
)

load("@io_bazel_rules_go//go:deps.bzl", "go_rules_dependencies")

go_rules_dependencies()
```
For JVM tests one would like to call the below instead of the above call to `bazel_binaries` since it does that plus more dependencies needed for `java_test`:
```python
Expand All @@ -78,7 +59,18 @@ bazel_java_integration_test_deps()
## Usage
### [Jvm](java/README.md)
### Go
TODO

[`rules_go`](https://github.com/bazelbuild/rules_go) already supports,
natively, an integration testing framework for validating your rules. If you
need to write integration tests, please refer to the
[godoc](https://godoc.org/github.com/bazelbuild/rules_go/go/tools/bazel_testing)
and associated
[`go_bazel_test` rule.](https://github.com/bazelbuild/rules_go/blob/master/go/tools/bazel_testing/def.bzl).
For example usage, `rules_go` itself is tested using this rule and many
packages inside of the
[`tests`](https://github.com/bazelbuild/rules_go/blob/master/tests/) package
can be used as examples.

### Python
TODO

Expand Down
30 changes: 0 additions & 30 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -90,36 +90,6 @@ jvm_maven_import_external(
],
)

## golang

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
name = "io_bazel_rules_go",
sha256 = "f04d2373bcaf8aa09bccb08a98a57e721306c8f6043a2a0ee610fd6853dcde3d",
urls = [
"https://github.com/bazelbuild/rules_go/releases/download/0.18.6/rules_go-0.18.6.tar.gz",
],
)

http_archive(
name = "bazel_gazelle",
sha256 = "d8c45ee70ec39a57e7a05e5027c32b1576cc7f16d9dd37135b0eddde45cf1b10",
urls = [
"https://github.com/bazelbuild/bazel-gazelle/releases/download/v0.20.0/bazel-gazelle-v0.20.0.tar.gz",
],
)

load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains()

load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")

gazelle_dependencies()

#### Use remote resources

## java
Expand Down
6 changes: 0 additions & 6 deletions bazel_integration_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ load(
"//tools:import.bzl",
bazel_external_dependency_archive_ = "bazel_external_dependency_archive",
)
load(
"//go:bazel_integration_test.bzl",
bazel_go_integration_test_ = "bazel_go_integration_test",
)

print(
"WARNING: bazel_integration_test.bzl is deprecated and will go away in " +
Expand All @@ -59,5 +55,3 @@ bazel_java_integration_test_deps = bazel_java_integration_test_deps_
bazel_py_integration_test = bazel_py_integration_test_

bazel_external_dependency_archive = bazel_external_dependency_archive_

bazel_go_integration_test = bazel_go_integration_test_
34 changes: 0 additions & 34 deletions go/BUILD

This file was deleted.

148 changes: 0 additions & 148 deletions go/bazel.go

This file was deleted.

55 changes: 0 additions & 55 deletions go/bazel_integration_test.bzl

This file was deleted.

Loading