-
Notifications
You must be signed in to change notification settings - Fork 29
Remove the go form of integration testing #170
Conversation
rules_go provides a better way to approach this problem.
@jayconrod @ittaiz since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Maybe this PR should add a link to this framework? In case someone wants to upgrade and sees the code is deleted so they’ll know what to move to. Maybe it should even be in the readme but I’m not sure about that.
Wdyt?
Also seems like there’s a problem with the CLA bot. Closing reopening to see if it will be fixed.
That didn’t help. Any thoughts what to do about the CLA check? |
@jayconrod, could you please poke the cla bot next time you're at your work computer |
wdyt about the link (readme or here) to the recommended way for go users? |
Did you look at the change? It has links and recommendations for what to do already in the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I reviewed the PR from the GitHub mobile app (my first) and missed it.
Feel free to merge when the CLA is fixed |
Not sure what's going on with the CLA. I'm guessing that GitHub sent a webhook request when a new commit was added and never got a response. I'll try removing the cla label and pinging the bot. If that doesn't work, I'll open a bug internally. |
Seems to have worked. @achew22 Thanks for updating this! |
rules_go provides a better way to approach this problem.