Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Remove the go form of integration testing #170

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Remove the go form of integration testing #170

merged 1 commit into from
Mar 23, 2020

Conversation

achew22
Copy link
Member

@achew22 achew22 commented Mar 21, 2020

rules_go provides a better way to approach this problem.

rules_go provides a better way to approach this problem.
@achew22
Copy link
Member Author

achew22 commented Mar 21, 2020

@jayconrod @ittaiz since rules_go provides a separate and better framework for doing this, I propose we remove the go section of this repo.

Copy link
Member

@ittaiz ittaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Maybe this PR should add a link to this framework? In case someone wants to upgrade and sees the code is deleted so they’ll know what to move to. Maybe it should even be in the readme but I’m not sure about that.
Wdyt?

Also seems like there’s a problem with the CLA bot. Closing reopening to see if it will be fixed.

@ittaiz ittaiz closed this Mar 22, 2020
@ittaiz ittaiz reopened this Mar 22, 2020
@ittaiz
Copy link
Member

ittaiz commented Mar 22, 2020

That didn’t help. Any thoughts what to do about the CLA check?

@achew22
Copy link
Member Author

achew22 commented Mar 22, 2020

@jayconrod, could you please poke the cla bot next time you're at your work computer

@ittaiz
Copy link
Member

ittaiz commented Mar 22, 2020

wdyt about the link (readme or here) to the recommended way for go users?

@achew22
Copy link
Member Author

achew22 commented Mar 22, 2020

Did you look at the change? It has links and recommendations for what to do already in the PR

Copy link
Member

@ittaiz ittaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I reviewed the PR from the GitHub mobile app (my first) and missed it.

@ittaiz
Copy link
Member

ittaiz commented Mar 22, 2020

Feel free to merge when the CLA is fixed

@jayconrod
Copy link

Not sure what's going on with the CLA. I'm guessing that GitHub sent a webhook request when a new commit was added and never got a response.

I'll try removing the cla label and pinging the bot. If that doesn't work, I'll open a bug internally.

@jayconrod
Copy link

Seems to have worked. @achew22 Thanks for updating this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants