Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jasmine_node_test that fails without fix from #633 #637

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Mar 29, 2019

Tests for failure reported in #632

@gregmagolan gregmagolan force-pushed the build/test-for-jasmine_node_test-require-regression branch from 17f6641 to 0154f55 Compare March 29, 2019 19:35
@gregmagolan
Copy link
Collaborator Author

Failure on master before #633 merged: https://circleci.com/gh/bazelbuild/rules_nodejs/7222#tests/containers/3

Running e2e test jasmine
checking deps: release jasmine
all deps built
+ yarn test
yarn run v1.13.0
warning package.json: No license field
$ ../../scripts/link_deps.sh
checking deps: release jasmine
all deps built
$ bazel test ...
Starting local Bazel server and connecting to it...
INFO: Options provided by the client:
  Inherited 'common' options: --isatty=0 --terminal_columns=0
INFO: Reading rc options for 'test' from /etc/bazel.bazelrc:
  Inherited 'build' options: --noshow_progress --announce_rc --local_resources=14336,8.0,1.0
INFO: Reading rc options for 'test' from /home/circleci/rules_nodejs/e2e/jasmine/.bazelrc:
  'test' options: --test_output=errors --nolegacy_external_runfiles
INFO: Analysed 6 targets (174 packages loaded, 4900 targets configured).
INFO: Found 3 targets and 3 test targets...
FAIL: //:shared_env_test (see /home/circleci/.cache/bazel/_bazel_circleci/6c2b76ea16fdfb70df802985cf6dd237/execroot/e2e_jasmine/bazel-out/k8-fastbuild/testlogs/shared_env_test/test.log)
INFO: From Testing //:shared_env_test:
==================== Test output for //:shared_env_test:
Started
....


4 specs, 0 failures
Finished in 0.005 seconds
================================================================================
INFO: Elapsed time: 20.415s, Critical Path: 1.51s
INFO: 6 processes: 6 processwrapper-sandbox.
//:coverage_test                                                         PASSED in 0.3s
//:test                                                                  PASSED in 0.1s
//:shared_env_test                                                       FAILED in 0.2s
  /home/circleci/.cache/bazel/_bazel_circleci/6c2b76ea16fdfb70df802985cf6dd237/execroot/e2e_jasmine/bazel-out/k8-fastbuild/testlogs/shared_env_test/test.log

Executed 3 out of 3 tests: 2 tests pass and 1 fails locally.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
error Command failed with exit code 3.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Exited with code 1

@gregmagolan gregmagolan force-pushed the build/test-for-jasmine_node_test-require-regression branch from 0154f55 to d54256f Compare March 29, 2019 19:44
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, I'll cut a release so we can roll to the ngrx repo

@alexeagle alexeagle merged commit 0e725ae into bazel-contrib:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants