Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jasmine_node_test can pick up wrong jasmine-core version #632

Closed
alexeagle opened this issue Mar 28, 2019 · 2 comments
Closed

jasmine_node_test can pick up wrong jasmine-core version #632

alexeagle opened this issue Mar 28, 2019 · 2 comments

Comments

@alexeagle
Copy link
Collaborator

Repro:

clone https://github.com/alexeagle/platform/tree/brokenz
bazel test //modules/effects/spec:test

All specs pass, but then jasmine exits with code 3 so Bazel thinks it failed.

I added some console logging, and here's the stack at the point that our jasmine_runner.js gets the completion event from jasmine:

Error: should be passed
    at jrunner.onComplete (node_modules/@bazel/jasmine/src/jasmine_runner.js:97:15)
    at module.exports.jasmineDone (node_modules/@bazel/jasmine/node_modules/jasmine/lib/reporters/completion_reporter.js:11:5)
    at dispatch (node_modules/jasmine-core/lib/jasmine-core/jasmine.js:2042:28)
    at ReportDispatcher.jasmineDone (node_modules/jasmine-core/lib/jasmine-core/jasmine.js:2013:11)
    at node_modules/jasmine-core/lib/jasmine-core/jasmine.js:780:18
    at ZoneDelegate.invokeTask (node_modules/zone.js/dist/zone-node.js:421:31)
    at Zone.runTask (node_modules/zone.js/dist/zone-node.js:188:47)
    at drainMicroTaskQueue (node_modules/zone.js/dist/zone-node.js:595:35)
    at ZoneTask.invokeTask (node_modules/zone.js/dist/zone-node.js:500:21)
    at Timeout.ZoneTask.invoke (node_modules/zone.js/dist/zone-node.js:485:48)
    at Timeout.timer [as _onTimeout] (node_modules/zone.js/dist/zone-node.js:2040:29)
    at ontimeout (timers.js:424:11)
    at tryOnTimeout (timers.js:288:5)
    at listOnTimeout (timers.js:251:5)
    at Timer.processTimers (timers.js:211:10)

Note that we get the jasmine library from node_modules/@bazel/jasmine/node_modules/jasmine so this will be the right version that @bazel/jasmine depends on - but we are picking up jasmine-core from node_modules/jasmine-core so I think the version skew is causing this.

@gregmagolan
Copy link
Collaborator

Fixed by #633

@gregmagolan
Copy link
Collaborator

Test for this case added in #637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants