fix(yarn): when running vendored yarn, prefix command with path to node #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we also need to put the node on the PATH before calling yarn since yarn scripts & programs called by yarn scripts can invoke "node" |
|
That seems like an existing bug actually. Nothing in our yarn repository adds such a thing to our yarn wrapper scripts, and when we invoke yarn install we don't do it there either. |
alexeagle
force-pushed
the
yarn_under_node
branch
2 times, most recently
from
2f78745 to
61dea3f
Compare
… node Otherwise we fall through to the system node on the PATH which may not be set, or may be skewed
alexeagle
force-pushed
the
yarn_under_node
branch
from
61dea3f to
1dc37c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we fall through to the system node on the PATH which may not be set, or may be skewed
rebased on #3250