*_install: only create nodejs or yarn repositories if we need them #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
alan-agius4,
gregmagolan,
jbedard and
mattem
as code owners
alexeagle
force-pushed
the
rm_auto_node_repositories
branch
2 times, most recently
from
f92ca47 to
72a85cf
Compare
|
What was the reason for it? Although deleting is always good 👍 |
|
It was just to make workspace files shorter in the common case. |
|
What made this a good idea at that client though? Mainly just curious... |
|
sorry, being too terse... I meant that at one client I'm seeing the wrong node downloaded so I think it may be a good idea to carry out this PR and remove this extra bit of syntax sugar to make things easier to understand. |
alexeagle
force-pushed
the
rm_auto_node_repositories
branch
4 times, most recently
from
ab3fb56 to
b350579
Compare
alexeagle
force-pushed
the
rm_auto_node_repositories
branch
5 times, most recently
from
a676ba2 to
f653326
Compare
alexeagle
changed the title
alexeagle
force-pushed
the
rm_auto_node_repositories
branch
from
f653326 to
7fd6e25
Compare
…ries This convenience is now too magical and confusing. If the user registers nodejs toolchains, this will create an extra toolchain they don't use, but can be fetched by rules that reference the default. It also makes a @Yarn workspace available even for users who only need npm. BREAKING CHANGE: you now need to explicitly register nodejs toolchains or use the node_repositories helper
alexeagle
force-pushed
the
rm_auto_node_repositories
branch
from
7fd6e25 to
fd31243
Compare
gregmagolan
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd create these repositories even if the user already installed node some other way.
Note, this is minor extra breaking change after rc1, but based on testing at one client I think this may be a good idea. This PR demonstrates how it caught some bugs in our e2e/examples where the wrong node (default version) was getting used.