-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builtin): flip the default of the strict_visibility flag on the npm and yarn install rules to True #2238
feat(builtin): flip the default of the strict_visibility flag on the npm and yarn install rules to True #2238
Conversation
829f068
to
16e157d
Compare
nice, I guess this is failing as expected |
Yes, these seem like legitimate missing dependencies. Working though them |
I was getting an error I think with karma and |
16e157d
to
ba93012
Compare
Hmm, I haven't see that. I did see an issue here of having a dependency on a |
Although that looks like it's actually my fault and this flag caught it? 😄 |
A bit odd that (sorry if this is getting off topic for this PR) |
567955f
to
819d7d4
Compare
I think the reason it's a peer dep is because it's listed here: |
Those integration tests could use the --keep_going flag! |
819d7d4
to
a1d0e1b
Compare
a1d0e1b
to
dd4edb8
Compare
…npm and yarn install rules to True
dd4edb8
to
9c883f8
Compare
🟢 finally. This change does mean that users will have to add the deps used by karma_web_test to their own package.json file if they haven't already, these are added by the karma_web_test macro, so it's a little abstracted from the BUILD files a user would see. |
That was the issue I came across. I had all of them except |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
I added a commit removing the "tmp" dependency. I don't think it's essential that we cleanup these files ourselves since they go in bazel's TEST_TMPDIR. |
@googlebot I consent. |
Can the "tmp" dependency change also go into 2.x? |
This is a potential breaking change for uses in 3.0.0
closes #2199