Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip strict_visibility flag on npm / yarn install rules #2199

Closed
mattem opened this issue Sep 17, 2020 · 1 comment
Closed

Flip strict_visibility flag on npm / yarn install rules #2199

mattem opened this issue Sep 17, 2020 · 1 comment
Assignees
@mattem
Labels
cleanup Tech debt, resolving it improves our own velocity
Milestone
3.0

Comments

@mattem
Copy link
Collaborator

mattem commented Sep 17, 2020

#2193 introduced the strict_visibility flag on npm_install and yarn_install which currently defaults False. As part of 3.0.0, default this flag True
@mattem mattem added the cleanup Tech debt, resolving it improves our own velocity label Sep 17, 2020
@mattem mattem added this to the 3.0 milestone Sep 17, 2020
@mattem mattem self-assigned this Sep 17, 2020
mattem added a commit to mattem/rules_nodejs that referenced this issue Oct 18, 2020
@mattem
feat(builtin): flip the default of the strict_visibility flag on npm …
b6cfbf2 
…and yarn install rules to True

closes: bazel-contrib#2199
@mattem mattem mentioned this issue Oct 18, 2020
Merged
@alexeagle
Copy link
Collaborator

fixed by #2238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattem mattem

Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@alexeagle @mattem