Fixes for npm_package: #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow source files to appear under deps, like .d.ts srcs of a ts_library - Include ts_library transitive_declarations - Include data attributes of ts_library Fixes bazel-contrib#196 Fixes bazel-contrib#197
Toxicable
pushed a commit
to Toxicable/rules_nodejs
that referenced
this pull request
Jul 21, 2018
* Fixes for npm_package: - Allow source files to appear under deps, like .d.ts srcs of a ts_library - Include ts_library transitive_declarations - Include data attributes of ts_library Fixes bazel-contrib#196 Fixes bazel-contrib#197 * Add tests for npm_package fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196
Fixes #197