Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm_package disallows .d.ts sources in ts_library #197

Closed
alexeagle opened this issue May 8, 2018 · 0 comments
Closed

npm_package disallows .d.ts sources in ts_library #197

alexeagle opened this issue May 8, 2018 · 0 comments
Assignees
@alexeagle

Comments

@alexeagle
Copy link
Collaborator

Found this with @hansl yesterday.

If you have types.d.ts -> ts_library#srcs -> npm_package#deps
then npm_package packager.js will fail with
dependency ${f} is not under bazel-bin or bazel-genfiles
@alexeagle alexeagle self-assigned this May 8, 2018
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue May 8, 2018
@alexeagle
Fixes for npm_package:
82842be 
- Allow source files to appear under deps, like .d.ts srcs of a ts_library
- Include ts_library transitive_declarations
- Include data attributes of ts_library

Fixes bazel-contrib#196
Fixes bazel-contrib#197
@alexeagle alexeagle mentioned this issue May 8, 2018
Merged
alexeagle added a commit that referenced this issue May 9, 2018
@alexeagle
Fixes for npm_package: (#198)
3a35786 
* Fixes for npm_package:

- Allow source files to appear under deps, like .d.ts srcs of a ts_library
- Include ts_library transitive_declarations
- Include data attributes of ts_library

Fixes #196
Fixes #197

* Add tests for npm_package fixes
Toxicable pushed a commit to Toxicable/rules_nodejs that referenced this issue Jul 21, 2018
@alexeagle
Fixes for npm_package: (bazel-contrib#198)
071b4bf 
* Fixes for npm_package:

- Allow source files to appear under deps, like .d.ts srcs of a ts_library
- Include ts_library transitive_declarations
- Include data attributes of ts_library

Fixes bazel-contrib#196
Fixes bazel-contrib#197

* Add tests for npm_package fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexeagle