Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup jasmine from_src index #1860

Merged
merged 1 commit into from
May 4, 2020

Conversation

alexeagle
Copy link
Collaborator

Instead, use replacements so the distribution uses different labels than we use locally

@alexeagle alexeagle force-pushed the jasmine_fromsrc branch 3 times, most recently from 36ad0a0 to 4a7f3eb Compare May 3, 2020 21:22
Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

Instead, use replacements so the distribution uses different labels than we use locally
@gregmagolan gregmagolan self-requested a review May 4, 2020 16:48
Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@alexeagle alexeagle requested a review from gregmagolan May 4, 2020 16:53
@alexeagle alexeagle closed this May 4, 2020
@alexeagle alexeagle deleted the jasmine_fromsrc branch May 4, 2020 18:35
@alexeagle alexeagle restored the jasmine_fromsrc branch May 4, 2020 18:41
@alexeagle alexeagle reopened this May 4, 2020
@gregmagolan gregmagolan merged commit 2e93d96 into bazel-contrib:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants