chore: cleanup jasmine from_src index (#1860)

Instead, use replacements so the distribution uses different labels than we use locally

examples/user_managed_deps/BUILD.bazel

@@ -1,5 +1,5 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 
 # Make the jasmine library available at runtime by exposing our node_modules
 # directory.
@@ -41,8 +41,8 @@ nodejs_binary(
 jasmine_node_test(
     name = "test",
     srcs = glob(["*.spec.js"]),
-    jasmine_deps = [],
     node_modules = "//:node_modules",
+    tags = ["no-local-jasmine-deps"],
     deps = [
         ":decrement",
         ":program",

internal/common/test/BUILD.bazel

@@ -1,5 +1,5 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("//internal/common:copy_to_bin.bzl", "copy_to_bin")
 load("//internal/common:params_file.bzl", "params_file")
 load(":expand_into_runfiles_test.bzl", "expand_into_runfiles_test_suite")

internal/linker/test/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 
 ts_library(

internal/linker/test/local/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 
 jasmine_node_test(
     name = "test",

internal/node/test/BUILD.bazel

@@ -1,7 +1,7 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary", "nodejs_test", "npm_package_bin")
 load("@build_bazel_rules_nodejs//internal/golden_file_test:golden_file_test.bzl", "golden_file_test")
 load("@npm//typescript:index.bzl", "tsc")
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("//internal/js_library:js_library.bzl", "js_library")
 load("//internal/node:node_repositories.bzl", "BUILT_IN_NODE_PLATFORMS")
 load("//third_party/github.com/bazelbuild/bazel-skylib:rules/copy_file.bzl", "copy_file")

internal/npm_install/test/BUILD.bazel

@@ -1,6 +1,6 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
 load("@build_bazel_rules_nodejs//internal/npm_install:npm_umd_bundle.bzl", "npm_umd_bundle")
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 
 filegroup(
     name = "goldens",
@@ -101,11 +101,12 @@ sh_test(
         "coarse.spec.js",
         "common.spec.js",
     ],
-    jasmine_deps = [
+    node_modules = "@fine_grained_deps_%s//:node_modules" % pkgmgr,
+    tags = ["no-local-jasmine-deps"],
+    deps = [
         "@fine_grained_deps_%s//jasmine" % pkgmgr,
         "@fine_grained_deps_%s//jasmine-core" % pkgmgr,
     ],
-    node_modules = "@fine_grained_deps_%s//:node_modules" % pkgmgr,
 ) for pkgmgr in [
     "yarn",
     "npm",
@@ -120,11 +121,10 @@ sh_test(
         "common.spec.js",
         "fine.spec.js",
     ],
-    jasmine_deps = [
+    tags = ["no-local-jasmine-deps"],
+    deps = [
         "@fine_grained_deps_%s//jasmine" % pkgmgr,
         "@fine_grained_deps_%s//jasmine-core" % pkgmgr,
-    ],
-    deps = [
         "@fine_grained_deps_%s//ajv" % pkgmgr,
         "@fine_grained_deps_%s//typescript" % pkgmgr,
         "@fine_grained_deps_%s//rxjs" % pkgmgr,

internal/pkg_npm/test/BUILD.bazel

@@ -1,5 +1,5 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_rollup//:index.bzl", "rollup_bundle")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load("//internal/node:context.bzl", "node_context_data")

internal/pkg_web/BUILD.bazel

@@ -2,7 +2,7 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
 
 # BEGIN-INTERNAL
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 
 # END-INTERNAL
 package(default_visibility = ["//visibility:public"])

internal/pkg_web/test/BUILD.bazel

@@ -1,6 +1,6 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "pkg_web")
 load("@npm//@babel/cli:index.bzl", "babel")
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_rollup//:index.bzl", "rollup_bundle")
 load("@npm_bazel_terser//:index.bzl", "terser_minified")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")

internal/pkg_web/test2/BUILD.bazel

@@ -1,6 +1,6 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "pkg_web")
 load("@npm//@babel/cli:index.bzl", "babel")
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_rollup//:index.bzl", "rollup_bundle")
 load("@npm_bazel_terser//:index.bzl", "terser_minified")
 

packages/jasmine/BUILD.bazel

@@ -42,6 +42,10 @@ pkg_npm(
         "@npm_bazel_jasmine//:package_contents",
     ],
     build_file_content = "",
+    substitutions = {
+        "@npm_bazel_jasmine//:jasmine__pkg": "@npm//@bazel/jasmine",
+        "@npm_bazel_jasmine//:jasmine_runner.js": "@npm//:node_modules/@bazel/jasmine/jasmine_runner.js",
+    },
     vendor_external = [
         "npm_bazel_jasmine",
     ],

packages/jasmine/src/jasmine_node_test.bzl

@@ -63,8 +63,10 @@ def jasmine_node_test(
         tags = [],
         config_file = None,
         coverage = False,
-        jasmine = "@npm//@bazel/jasmine",
-        jasmine_entry_point = "@npm//:node_modules/@bazel/jasmine/jasmine_runner.js",
+        # Replaced by pkg_npm with jasmine = "@npm//@bazel/jasmine",
+        jasmine = "@npm_bazel_jasmine//:jasmine__pkg",
+        # Replaced by pkg_npm with jasmine_entry_point = "@npm//:node_modules/@bazel/jasmine/jasmine_runner.js",
+        jasmine_entry_point = "@npm_bazel_jasmine//:jasmine_runner.js",
         **kwargs):
     """Runs tests in NodeJS using the Jasmine test runner.
 
@@ -104,6 +106,13 @@ def jasmine_node_test(
 
     all_data = data + srcs + deps + [Label(jasmine)]
 
+    # BEGIN-INTERNAL
+    # Only used when running tests in the rules_nodejs repo.
+    # Avoid adding duplicate deps though, some rules use this from source and declared the dep
+    if not "@npm//jasmine" in all_data and not str(Label("@npm//jasmine")) in all_data and not "no-local-jasmine-deps" in tags:
+        all_data.extend(["@npm//jasmine", "@npm//jasmine-reporters", "@npm//v8-coverage"])
+
+    # END-INTERNAL
     all_data += [":%s_devmode_srcs.MF" % name]
     all_data += [Label("@build_bazel_rules_nodejs//third_party/github.com/bazelbuild/bazel/tools/bash/runfiles")]
 

packages/jasmine/test/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("//internal/common:copy_to_bin.bzl", "copy_to_bin")
 
 jasmine_node_test(

packages/karma/test/karma_typescript/BUILD.bazel

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_karma//:index.bzl", "karma_web_test_suite")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 

packages/labs/test/grpc_web/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_karma//:index.bzl", "karma_web_test_suite")
 load("@npm_bazel_rollup//:index.bzl", "rollup_bundle")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")

packages/labs/test/protobufjs/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_labs//:index.bzl", "protobufjs_ts_library")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load("@rules_proto//proto:defs.bzl", "proto_library")

packages/protractor/test/protractor-utils/BUILD.bazel

@@ -1,5 +1,5 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 
 ts_library(

packages/rollup/test/code_splitting/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_rollup//:index.bzl", "rollup_bundle")
 
 rollup_bundle(

packages/rollup/test/multiple_entry_points/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_rollup//:index.bzl", "rollup_bundle")
 
 rollup_bundle(

packages/rollup/test/sourcemaps/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_rollup//:index.bzl", "rollup_bundle")
 
 rollup_bundle(

packages/terser/test/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 
 jasmine_node_test(
     name = "test",

packages/terser/test/directory_input/BUILD.bazel

@@ -1,5 +1,5 @@
 load("@build_bazel_rules_nodejs//:tools/declare_directory.bzl", "declare_directory")
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_terser//:index.bzl", "terser_minified")
 
 declare_directory(

packages/terser/test/exec/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 
 jasmine_node_test(
     name = "test",

packages/terser/test/inline_sourcemap/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_terser//:index.bzl", "terser_minified")
 
 # Check that filegroups work

packages/terser/test/sourcemap/BUILD.bazel

@@ -1,5 +1,5 @@
 load("@build_bazel_rules_nodejs//:tools/declare_directory.bzl", "declare_directory")
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_terser//:index.bzl", "terser_minified")
 
 filegroup(

packages/typescript/test/angular_plugin/compiled_output/BUILD.bazel

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 
 ts_library(

packages/typescript/test/googmodule/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load("//packages/typescript/test/devmode_consumer:devmode_consumer.bzl", "devmode_consumer")
 

packages/typescript/test/reference_types_directive/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 
 ts_library(

packages/typescript/test/target_module_attributes/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load("//packages/typescript/test/devmode_consumer:devmode_consumer.bzl", "devmode_consumer")
 load("//packages/typescript/test/es6_consumer:es6_consumer.bzl", "es6_consumer")

packages/typescript/test/ts_project/b/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
+load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_typescript//:index.bzl", "ts_project")
 
 package(default_visibility = ["//packages/typescript/test:__subpackages__"])