Skip to content

Commit

Permalink
chore: tsc_wrapped worker mode needs require patches
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex Eagle committed Dec 10, 2020
1 parent 9a5a5c1 commit 5caf332
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,6 @@ tasks:
# TODO(gregmagolan): figure out how to install missing shared libs
# Without this filter the @cypress external repository will be built and that build will fail due to missing shared libs.
- "--build_tag_filters=-cypress,-pkg_npm.pack"
- "--define=NODE_DEBUG=module"
- "--define=VERBOSE_LOGS=1"
test_flags:
# TODO(gregmagolan): figure out how to install missing shared libs
- "--test_arg=-cypress"
2 changes: 2 additions & 0 deletions examples/angular/tools/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,7 @@ nodejs_binary(
"@npm//@bazel/typescript",
],
entry_point = "@npm//:node_modules/@bazel/typescript/internal/tsc_wrapped/tsc_wrapped.js",
# TODO: turn on --worker_sandboxing and remove this flag to see failure to load the plugin
templated_args = ["--bazel_patch_module_resolver"],
visibility = ["//:__subpackages__"],
)
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ nodejs_binary(
],
entry_point = ":tsc_wrapped/tsc_wrapped.js",
visibility = ["//visibility:public"],
# With RBE or --worker_sandboxing you'll see that worker doesn't run_node
# so it doesn't have the linker
templated_args = ["--bazel_patch_module_resolver"],
)

ts_library(
Expand Down

0 comments on commit 5caf332

Please sign in to comment.