chore: try to fix remaining CI failures for --nobazel_patch_module_re…

…solver
bazel-contrib · Dec 10, 2020 · 9a5a5c1 · 9a5a5c1
1 parent 6bf8ae7
commit 9a5a5c1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml
@@ -447,6 +447,8 @@ tasks:
     # TODO(gregmagolan): figure out how to install missing shared libs
     # Without this filter the @cypress external repository will be built and that build will fail due to missing shared libs.
     - "--build_tag_filters=-cypress,-pkg_npm.pack"
+    - "--define=NODE_DEBUG=module"
+    - "--define=VERBOSE_LOGS=1"
     test_flags:
     # TODO(gregmagolan): figure out how to install missing shared libs
     - "--test_arg=-cypress"
diff --git a/packages/labs/protobufjs/BUILD.bazel b/packages/labs/protobufjs/BUILD.bazel
@@ -43,7 +43,11 @@ nodejs_binary(
         "@build_bazel_rules_typescript_protobufs_compiletime_deps//estraverse",
     ],
     entry_point = "@build_bazel_rules_typescript_protobufs_compiletime_deps//:node_modules/protobufjs/bin/pbjs",
-    templated_args = ["--nobazel_run_linker"],
+    # TODO: remove these flags, make this resolve dependencies via the linker
+    templated_args = [
+        "--bazel_patch_module_resolver",
+        "--nobazel_run_linker",
+    ],
 )
 
 nodejs_binary(
@@ -66,7 +70,11 @@ nodejs_binary(
         "@build_bazel_rules_typescript_protobufs_compiletime_deps//estraverse",
     ],
     entry_point = "@build_bazel_rules_typescript_protobufs_compiletime_deps//:node_modules/protobufjs/bin/pbts",
-    templated_args = ["--nobazel_run_linker"],
+    # TODO: remove these flags, make this resolve dependencies via the linker
+    templated_args = [
+        "--bazel_patch_module_resolver",
+        "--nobazel_run_linker",
+    ],
 )
 
 # Runtime libraries needed by the protobufjs library.