Load JavaInfo and java_common from rules_java
#1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares rules_jvm_external for bazelbuild/bazel#19455 Closes bazel-contrib#967 which has been left in limbo.
fmeum
reviewed
Jan 6, 2024
| @@ -11,18 +11,20 @@ bazel_dep( | |||
| name = "platforms", | |||
| version = "0.0.8", | |||
| ) | |||
| bazel_dep( | |||
| name = "rules_java", | |||
| version = "7.3.2", | |||
There was a problem hiding this comment.
I would recommend staying on a lower version as this one requires Bazel 7. 7.2.0 still works with Bazel 6.4.0.
There was a problem hiding this comment.
We already use use_repo_rule, so we're already expecting Bazel 7 when people use bzlmod
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Jan 10, 2024
This change makes our Bazel build compatible with all the migration-ready `--incompatible` flags listed [here](https://github.com/bazelbuild/bazel/releases/tag/7.0.0) for Bazel 7.0, with a couple exceptions listed below. This was mostly just a matter of updating some of our dependencies to more recent versions. The two flags we cannot support yet are these: - `--incompatible_disallow_struct_provider_syntax`: Bazel itself appears not to support this one yet, see [here](bazelbuild/bazel#19467). - `--incompatible_stop_exporting_language_modules`: waiting on support in `rules_jvm_external`, see [here](bazel-contrib/rules_jvm_external#1027). I also deleted the broken `//:protobuf_nowkt` alias target, which was an oversight on my part from a previous change. PiperOrigin-RevId: 597076542
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Jan 10, 2024
This change makes our Bazel build compatible with all the migration-ready `--incompatible` flags listed [here](https://github.com/bazelbuild/bazel/releases/tag/7.0.0) for Bazel 7.0, with a couple exceptions listed below. This was mostly just a matter of updating some of our dependencies to more recent versions. The two flags we cannot support yet are these: - `--incompatible_disallow_struct_provider_syntax`: Bazel itself appears not to support this one yet, see [here](bazelbuild/bazel#19467). - `--incompatible_stop_exporting_language_modules`: waiting on support in `rules_jvm_external`, see [here](bazel-contrib/rules_jvm_external#1027). I also deleted the broken `//:protobuf_nowkt` alias target, which was an oversight on my part from a previous change. PiperOrigin-RevId: 597076542
jin
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares rules_jvm_external for bazelbuild/bazel#19455
Closes #967 which has been left in limbo.