-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk.bzl: include go.env since 1.21.0 #3666
Conversation
Include go.env file in the root of the sdk repo starting from Go 1.21.0.
94df77f
to
2ef8a76
Compare
for reference, this is the content of the file. |
@sluongng Could you submit the update to Go SDK 1.21.0 combined with the revert of the earlier approach to fix the GO_PROXY issue? The work should be done and that way we can test that's actually the case. Thank you very much for driving these fixes! |
I don't think we need a revert on Gazelle side just yet. Instead, let's proceed with the Go SDK upgrade in rules_go. WDYT? |
This reverts commit adce430. We found an alternative fix to this to this issue in bazel-contrib/rules_go#3666.
This reverts commit adce430. We found an alternative fix to this to this issue in bazel-contrib/rules_go#3666.
Upgrade rules_go to latest commit in `master` at the moment of writing. Unblocks Go 1.21 upgrade in #4516 by including the fixes in: - bazel-contrib/rules_go#3660 - bazel-contrib/rules_go#3666
Upgrade rules_go to latest commit in `master` at the moment of writing. Unblocks Go 1.21 upgrade in #4516 by including the fixes in: - bazel-contrib/rules_go#3660 - bazel-contrib/rules_go#3666
Go 1.21 added a requirement for a 'go.env' file. Without that file, Go will throw an error like: ``` Error in fail: failed to fetch org_golang_google_grpc_cmd_protoc_gen_go_grpc: fetch_repo: google.golang.org/grpc/cmd/[email protected]: GOPROXY list is not the empty string, but contains no entries ``` This commit adds it to the SDK exposed by rules_nixpkgs so that it is compatible with rules_go. See: - bazel-contrib/rules_go#3665 - bazel-contrib/rules_go#3666
Go 1.21 added a requirement for a 'go.env' file. Without that file, Go will throw an error like: ``` Error in fail: failed to fetch org_golang_google_grpc_cmd_protoc_gen_go_grpc: fetch_repo: google.golang.org/grpc/cmd/[email protected]: GOPROXY list is not the empty string, but contains no entries ``` This commit adds it to the SDK exposed by rules_nixpkgs so that it is compatible with rules_go. See: - bazel-contrib/rules_go#3665 - bazel-contrib/rules_go#3666
…" (bazel-contrib#1609) This reverts commit adce430. We found an alternative fix to this to this issue in bazel-contrib/rules_go#3666.
Include go.env file in the root of the sdk repo starting from Go 1.21.0.
Fixes #3665