Add support for Go 1.21 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malt3
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
LGTM. My team is using this patch in our Go monorepo for over a month now.
This works for old and new go versions and passes the unit tests on my machine.
Just a very gentle reminder that this PR is required for go 1.21 support and can be merged @benradf @aherrmann
benradf
approved these changes
Nov 3, 2023
|
@Mergifyio rebase |
Go 1.21 added a requirement for a 'go.env' file. Without that file, Go will throw an error like: ``` Error in fail: failed to fetch org_golang_google_grpc_cmd_protoc_gen_go_grpc: fetch_repo: google.golang.org/grpc/cmd/[email protected]: GOPROXY list is not the empty string, but contains no entries ``` This commit adds it to the SDK exposed by rules_nixpkgs so that it is compatible with rules_go. See: - bazel-contrib/rules_go#3665 - bazel-contrib/rules_go#3666
✅ Branch has been successfully rebased |
avdv
added a commit
to tweag/gazelle_haskell_modules
that referenced
this pull request
Mar 19, 2024
Using go 1.21 fails with `GOPROXY list is not the empty string, but contains no entries`. See tweag/rules_nixpkgs#417
avdv
added a commit
to tweag/gazelle_haskell_modules
that referenced
this pull request
Mar 19, 2024
Using go 1.21 fails with `GOPROXY list is not the empty string, but contains no entries`. See tweag/rules_nixpkgs#417
avdv
added a commit
to tweag/gazelle_haskell_modules
that referenced
this pull request
Mar 19, 2024
Using go 1.21 fails with `GOPROXY list is not the empty string, but contains no entries`. See tweag/rules_nixpkgs#417
avdv
added a commit
to tweag/gazelle_cabal
that referenced
this pull request
May 22, 2024
Using go 1.21 fails with `GOPROXY list is not the empty string, but contains no entries`. See tweag/rules_nixpkgs#417
avdv
added a commit
to tweag/gazelle_cabal
that referenced
this pull request
May 22, 2024
Using go 1.21 fails with `GOPROXY list is not the empty string, but contains no entries`. See tweag/rules_nixpkgs#417
avdv
added a commit
to tweag/gazelle_cabal
that referenced
this pull request
May 22, 2024
Using go 1.21 fails with `GOPROXY list is not the empty string, but contains no entries`. See tweag/rules_nixpkgs#417
avdv
added a commit
to tweag/gazelle_cabal
that referenced
this pull request
May 22, 2024
Using go 1.21 fails with `GOPROXY list is not the empty string, but contains no entries`. See tweag/rules_nixpkgs#417
avdv
added a commit
to tweag/gazelle_cabal
that referenced
this pull request
May 29, 2024
Using go 1.21 fails with `GOPROXY list is not the empty string, but contains no entries`. See tweag/rules_nixpkgs#417
avdv
added a commit
to tweag/gazelle_haskell_modules
that referenced
this pull request
Sep 3, 2024
Newer go versions need at least rules_nixpkgs 0.11, see tweag/rules_nixpkgs#417.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.21 added a requirement for a 'go.env' file. Without that file, Go will throw an error like:
This commit adds it to the SDK exposed by rules_nixpkgs so that it is compatible with rules_go.
See: