Remove dependencie with bazelbuild/rules_cc #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long time ago Bazel was saying that cc_binary, cc_library, cc_test and the other cc_* rules should be imported from rules_cc. However rules_cc was always saying that there is no need to use them yet. After several discussions it was clarified that migration to bazelbuild/rules_cc was put on hold and there is not need to the users that they start using it. One of the reasons why a person would not want to use rules_cc right now is because there is no release and there is no notion of what is a good commit: bazelbuild/rules_cc#91 bazelbuild/rules_cc#68 The fact that rules_go depends on rules_cc forces any rules_go user to use rules_cc. Considering that rules_docker depends on rules_go, any rules_docker user is also forced to depend on rules_cc. More information about the discussions: bazelbuild/rules_cc#86 bazelbuild/rules_cc#92 bazelbuild/buildtools#923 bazelbuild/buildtools#952 Fixes bazel-contrib#2949
limdor
force-pushed
the
remove_rules_cc
branch
from
4728803 to
da28548
Compare
|
Based on @oquenchil 's comments in bazelbuild/rules_cc#91 (comment):
it seems that |
rHermes
added a commit
to rHermes/benchmark
that referenced
this pull request
Nov 14, 2021
It seems according to [1] that bazelbuild/rules_cc has been put on hold and that the recommended way for now, is to use the native cc rules. [1]: bazel-contrib/rules_go#2950
dmah42
pushed a commit
to google/benchmark
that referenced
this pull request
Nov 14, 2021
It seems according to [1] that bazelbuild/rules_cc has been put on hold and that the recommended way for now, is to use the native cc rules. [1]: bazel-contrib/rules_go#2950
sergiud
pushed a commit
to sergiud/benchmark
that referenced
this pull request
Jan 13, 2022
It seems according to [1] that bazelbuild/rules_cc has been put on hold and that the recommended way for now, is to use the native cc rules. [1]: bazel-contrib/rules_go#2950
dneto0
added a commit
to dneto0/effcee
that referenced
this pull request
Dec 21, 2022
Stop using an external rules_cc dependency. Use internal C/C++ rules instead. - Follows googletest in doing this. google/googletest#3574 - See also: bazel-contrib/rules_go#2950 This appears necessary for compatibility with Bazel 5.0.0 and Bazel 6.0.0 Update to googletest-release-1.12.1, the last release that only needs a C++11 compiler, and doesn't require C++14. Update to re2-2022-12-01 I have successfully built and tested effcee with this configuration on Linux x86-64 with Bazel 5.0.0 and Bazel 6.0.0.
dneto0
added a commit
to google/effcee
that referenced
this pull request
Dec 21, 2022
Stop using an external rules_cc dependency. Use internal C/C++ rules instead. - Follows googletest in doing this. google/googletest#3574 - See also: bazel-contrib/rules_go#2950 This appears necessary for compatibility with Bazel 5.0.0 and Bazel 6.0.0 Update to googletest-release-1.12.1, the last release that only needs a C++11 compiler, and doesn't require C++14. Update to re2-2022-12-01 I have successfully built and tested effcee with this configuration on Linux x86-64 with Bazel 5.0.0 and Bazel 6.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time ago Bazel was saying that cc_binary, cc_library, cc_test and the other cc_* rules should be imported from rules_cc.
However rules_cc was always saying that there is no need to use them yet.
After several discussions it was clarified that migration to bazelbuild/rules_cc was put on hold and there is not need to the users that they start using it.
One of the reasons why a person would not want to use rules_cc right now is because there is no release and there is no notion of what is a good commit:
bazelbuild/rules_cc#91
bazelbuild/rules_cc#68
The fact that rules_go depends on rules_cc forces any rules_go user to use rules_cc. Considering that rules_docker depends on rules_go, any rules_docker user is also forced to depend on rules_cc.
More information about the discussions:
bazelbuild/rules_cc#86
bazelbuild/rules_cc#92
bazelbuild/buildtools#923
bazelbuild/buildtools#952
Fixes #2949