-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependencie with bazelbuild/rules_cc #2949
Comments
This seems like a really good first contribution to the project. I'm really excited that you're looking to get involved. How can I help empower you to make this change? I'm very happy to review any prs you might have on this front |
For the moment knowing that you are opened to this change is enough. I'll
prepare a PR and if I have issues I'll let you know.
Andrew Z Allen ***@***.***> schrieb am Do., 9. Sep. 2021,
17:17:
… This seems like a really good first contribution to the project. I'm
really excited that you're looking to get involved. How can I help empower
you to make this change? I'm very happy to review any prs you might have on
this front
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2949 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXONNK7VTZ33DN3UYI2OBTUBDFYFANCNFSM5DQNFRZA>
.
|
Long time ago Bazel was saying that cc_binary, cc_library, cc_test and the other cc_* rules should be imported from rules_cc. However rules_cc was always saying that there is no need to use them yet. After several discussions it was clarified that migration to bazelbuild/rules_cc was put on hold and there is not need to the users that they start using it. One of the reasons why a person would not want to use rules_cc right now is because there is no release and there is no notion of what is a good commit: bazelbuild/rules_cc#91 bazelbuild/rules_cc#68 The fact that rules_go depends on rules_cc forces any rules_go user to use rules_cc. Considering that rules_docker depends on rules_go, any rules_docker user is also forced to depend on rules_cc. More information about the discussions: bazelbuild/rules_cc#86 bazelbuild/rules_cc#92 bazelbuild/buildtools#923 bazelbuild/buildtools#952 Fixes bazel-contrib#2949
Long time ago Bazel was saying that cc_binary, cc_library, cc_test and the other cc_* rules should be imported from rules_cc. However rules_cc was always saying that there is no need to use them yet. After several discussions it was clarified that migration to bazelbuild/rules_cc was put on hold and there is not need to the users that they start using it. One of the reasons why a person would not want to use rules_cc right now is because there is no release and there is no notion of what is a good commit: bazelbuild/rules_cc#91 bazelbuild/rules_cc#68 The fact that rules_go depends on rules_cc forces any rules_go user to use rules_cc. Considering that rules_docker depends on rules_go, any rules_docker user is also forced to depend on rules_cc. More information about the discussions: bazelbuild/rules_cc#86 bazelbuild/rules_cc#92 bazelbuild/buildtools#923 bazelbuild/buildtools#952 Fixes bazel-contrib#2949
@achew22 here the PR #2950 |
Long time ago Bazel was saying that cc_binary, cc_library, cc_test and the other cc_* rules should be imported from rules_cc. However rules_cc was always saying that there is no need to use them yet. After several discussions it was clarified that migration to bazelbuild/rules_cc was put on hold and there is not need to the users that they start using it. One of the reasons why a person would not want to use rules_cc right now is because there is no release and there is no notion of what is a good commit: bazelbuild/rules_cc#91 bazelbuild/rules_cc#68 The fact that rules_go depends on rules_cc forces any rules_go user to use rules_cc. Considering that rules_docker depends on rules_go, any rules_docker user is also forced to depend on rules_cc. More information about the discussions: bazelbuild/rules_cc#86 bazelbuild/rules_cc#92 bazelbuild/buildtools#923 bazelbuild/buildtools#952 Fixes: #2949
What version of rules_go are you using?
master (v0.28.0)
What version of gazelle are you using?
Not relevant, gazelle does not depend on rules_cc
What version of Bazel are you using?
Not relevant, it would affect al Bazel versions, but in my case Bazel 4 LTS
What did you do?
Inspect rules_go dependencies.
Long time ago Bazel was saying that cc_binary, cc_library, cc_test and the other cc_* rules should be imported from rules_cc.
However rules_cc was always saying that there is no need to use them yet.
After several discussions it was clarified that migration to bazelbuild/rules_cc was put on hold and there is not need to the users that they start using it.
One of the reasons why a person would not want to use rules_cc right now is because there is no release and there is no notion of what is a good commit:
bazelbuild/rules_cc#91
bazelbuild/rules_cc#68
The fact that rules_go depends on rules_cc forces any rules_go user to use rules_cc. Considering that rules_docker depends on rules_go, any rules_docker user is also forced to depend on rules_cc.
More information about the discussions:
bazelbuild/rules_cc#86
bazelbuild/rules_cc#92
bazelbuild/buildtools#923
bazelbuild/buildtools#952
What did you expect to see?
I would request rules_go to stop depending on rules_cc and go back to use the native Bazel cc_* rules until rules_cc creates a release. "ith this way the users of rules_go or rules_docker are also not force to use rules_cc.
If the team of rules_go agrees I can offer myself on preparing a PR for it.
The text was updated successfully, but these errors were encountered: