-
-
Notifications
You must be signed in to change notification settings - Fork 664
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
**What type of PR is this?** Documentation **What does this PR do? Why is it needed?** Crosstool is the old way in Bazel to define a C/C++ toolchain. It has been deprecated and replaced with the new toolchain + platforms auto resolve system in recent years. The current docs in rules_go are out-of-date with a huge disclaimer up top. Several links still point to the old Wiki page which has already been moved to ./docs/ dir. This PR does 2 things: 1. Rename `crosstool` attribute in Go Context in starlark to `cc_toolchain_files`. This new name better communicates the actual usage of the attribute, which is to propagate all CC toolchain files to Go actions. 2. Remove `go/crosstool.rst` doc entirely and update out-of-date crosstool references to point to the new platforms and toolchains doc. **Which issues(s) does this PR fix?** **Other notes for review**
- Loading branch information
Showing
11 changed files
with
19 additions
and
367 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.