rm crosstool #3986
Merged
rm crosstool #3986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
force-pushed
the
sluongng/rm-crosstool
branch
from
92cc72d to
aedd944
Compare
fmeum
reviewed
Jul 9, 2024
fmeum
approved these changes
Jul 10, 2024
|
I'll try to fix ci over on the FS PR first. |
|
I think this PR should be safe to merge now? |
fmeum
force-pushed
the
sluongng/rm-crosstool
branch
from
0009b3f to
ea13333
Compare
This was referenced Aug 14, 2024
fmeum
pushed a commit
that referenced
this pull request
Aug 14, 2024
**What type of PR is this?** Documentation **What does this PR do? Why is it needed?** Add missing link to https://bazel.build/extending/toolchains#toolchain-definitions for the change introduced by #3986. **Which issues(s) does this PR fix?** `None` **Other notes for review** `None`
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/bazel-starlib
Aug 30, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://redirect.github.com/bazelbuild/rules_go) | http_archive | minor | `v0.49.0` -> `v0.50.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.50.0`](https://redirect.github.com/bazelbuild/rules_go/releases/tag/v0.50.0) [Compare Source](https://redirect.github.com/bazelbuild/rules_go/compare/v0.49.0...v0.50.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "67b4d1f517ba73e0a92eb2f57d821f2ddc21f5bc2bd7a231573f11bd8758192e", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.50.0/rules_go-v0.50.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.50.0/rules_go-v0.50.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.23.0") #### What's Changed - Break reliance on GOROOT_FINAL by [@​JacobOaks](https://redirect.github.com/JacobOaks) in [https://github.com/bazelbuild/rules_go/pull/3984](https://redirect.github.com/bazelbuild/rules_go/pull/3984) - Migrate to macos_arm64 by [@​meteorcloudy](https://redirect.github.com/meteorcloudy) in [https://github.com/bazelbuild/rules_go/pull/3990](https://redirect.github.com/bazelbuild/rules_go/pull/3990) - Support matching release candidate toolchain versions by [@​JacobOaks](https://redirect.github.com/JacobOaks) in [https://github.com/bazelbuild/rules_go/pull/3998](https://redirect.github.com/bazelbuild/rules_go/pull/3998) - rm crosstool by [@​sluongng](https://redirect.github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3986](https://redirect.github.com/bazelbuild/rules_go/pull/3986) - fix(timeout.go): remove redundant leaked go func in RegisterTimeoutHandler by [@​Roytangrb](https://redirect.github.com/Roytangrb) in [https://github.com/bazelbuild/rules_go/pull/4004](https://redirect.github.com/bazelbuild/rules_go/pull/4004) - Run nogo in a separate validation action by [@​fmeum](https://redirect.github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3995](https://redirect.github.com/bazelbuild/rules_go/pull/3995) #### New Contributors - [@​JacobOaks](https://redirect.github.com/JacobOaks) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3984](https://redirect.github.com/bazelbuild/rules_go/pull/3984) - [@​Roytangrb](https://redirect.github.com/Roytangrb) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/4004](https://redirect.github.com/bazelbuild/rules_go/pull/4004) **Full Changelog**: bazel-contrib/rules_go@release-0.49...release-0.50 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OC4wIiwidXBkYXRlZEluVmVyIjoiMzguNTguMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: cgrindel-self-hosted-renovate[bot] <139595543+cgrindel-self-hosted-renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in kreempuff/rules_unreal_engine
Aug 30, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.49.0` -> `v0.50.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.50.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.50.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.49.0...v0.50.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "67b4d1f517ba73e0a92eb2f57d821f2ddc21f5bc2bd7a231573f11bd8758192e", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.50.0/rules_go-v0.50.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.50.0/rules_go-v0.50.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.23.0") #### What's Changed - Break reliance on GOROOT_FINAL by [@​JacobOaks](https://togithub.com/JacobOaks) in [https://github.com/bazelbuild/rules_go/pull/3984](https://togithub.com/bazelbuild/rules_go/pull/3984) - Migrate to macos_arm64 by [@​meteorcloudy](https://togithub.com/meteorcloudy) in [https://github.com/bazelbuild/rules_go/pull/3990](https://togithub.com/bazelbuild/rules_go/pull/3990) - Support matching release candidate toolchain versions by [@​JacobOaks](https://togithub.com/JacobOaks) in [https://github.com/bazelbuild/rules_go/pull/3998](https://togithub.com/bazelbuild/rules_go/pull/3998) - rm crosstool by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3986](https://togithub.com/bazelbuild/rules_go/pull/3986) - fix(timeout.go): remove redundant leaked go func in RegisterTimeoutHandler by [@​Roytangrb](https://togithub.com/Roytangrb) in [https://github.com/bazelbuild/rules_go/pull/4004](https://togithub.com/bazelbuild/rules_go/pull/4004) - Run nogo in a separate validation action by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3995](https://togithub.com/bazelbuild/rules_go/pull/3995) #### New Contributors - [@​JacobOaks](https://togithub.com/JacobOaks) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3984](https://togithub.com/bazelbuild/rules_go/pull/3984) - [@​Roytangrb](https://togithub.com/Roytangrb) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/4004](https://togithub.com/bazelbuild/rules_go/pull/4004) **Full Changelog**: bazel-contrib/rules_go@release-0.49...release-0.50 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Documentation
What does this PR do? Why is it needed?
Crosstool is the old way in Bazel to define a C/C++ toolchain.
It has been deprecated and replaced with the new toolchain + platforms auto resolve system in recent years.
The current docs in rules_go are out-of-date with a huge disclaimer up top.
Several links still point to the old Wiki page which has already been moved to ./docs/ dir.
This PR does 2 things:
Rename
crosstoolattribute in Go Context in starlark tocc_toolchain_files.This new name better communicates the actual usage of the attribute, which is to propagate all
CC toolchain files to Go actions.
Remove
go/crosstool.rstdoc entirely and update out-of-date crosstool references to point tothe new platforms and toolchains doc.
Which issues(s) does this PR fix?
Other notes for review