Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(timeout.go): remove redundant leaked go func in RegisterTimeoutHa…
…ndler (#4004) <!-- Thanks for sending a PR! Before submitting: 1. If this is your first PR, please read CONTRIBUTING.md and sign the CLA first. We cannot review code without a signed CLA. 2. Please file an issue *first*. All features and most bug fixes should have an associated issue with a design discussed and decided upon. Small bug fixes and documentation improvements don't need issues. 3. New features and bug fixes must have tests. Documentation may need to be updated. If you're unsure what to update, send the PR, and we'll discuss in review. 4. Note that PRs updating dependencies and new Go versions are not accepted. Please file an issue instead. --> **What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** Fix #4003 The removed goroutine is redundant and will fail user code tests where timeout or sigterm do no happen. IIUC, we only need to register a noop handler for sigterm signal for bazel to gracefully shutdown in case of a test timeout and `signal.Notify(c, signal.SIGTERM)` create a strong reference to prevent `c` from being GCed when `RegisterTimeoutHandler` returns. **Which issues(s) does this PR fix?** Fixes #4003 **Other notes for review** Tested with my own repo tests and a simple time.Sleep ran with --test_timeout
- Loading branch information