Skip to content

Commit

Permalink
test: embed parsing break on double quote rune
Browse files Browse the repository at this point in the history
rename fixture file
  • Loading branch information
andyscott committed Nov 15, 2023
1 parent f2d409b commit 5c4056d
Show file tree
Hide file tree
Showing 3 changed files with 67 additions and 0 deletions.
7 changes: 7 additions & 0 deletions go/tools/builders/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ go_test(
"filter.go",
"filter_test.go",
"read.go",
"read_test.go",
],
data = [
"read_test_fixture.go",
],
deps = [
"//go/runfiles",
],
)

Expand Down
45 changes: 45 additions & 0 deletions go/tools/builders/read_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/* Copyright 2016 The Bazel Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package main

import (
"go/build"
"testing"

"github.com/bazelbuild/rules_go/go/runfiles"
)

func TestReadFileInfoEmbeds(t *testing.T) {
rf, err := runfiles.New()
if err != nil {
t.Fatalf("Error creating runfiles: %v", err)
}

f, err := rf.Rlocation("io_bazel_rules_go/go/tools/builders/read_test_fixture.go")
if err != nil {
t.Fatalf("Unable to get test file: %v", err)
}

fileInfo, err := readFileInfo(build.Default, f)
if err != nil {
t.Fatalf("readFileInfo: %v", err)
}

numExpectedEmbeds := 2
if len(fileInfo.embeds) != numExpectedEmbeds {
t.Fatalf("did not find expected number of file embeds! found %d got %d", len(fileInfo.embeds), numExpectedEmbeds)
}
}
15 changes: 15 additions & 0 deletions go/tools/builders/read_test_fixture.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package main

import (
_ "embed"
)

//go:embed before.sql
var beforeDoubleQuoteRune string

func doubleQuoteRune() {
rune := '"'
}

//go:embed after.sql
var afterDoubleQuoteRune string

0 comments on commit 5c4056d

Please sign in to comment.