upgrade x/tools to 0.15.0 (#3751)

bazel-contrib · Nov 13, 2023 · f2d409b · f2d409b
1 parent e9363db
commit f2d409b
Show file tree

Hide file tree

Showing 6 changed files with 22,350 additions and 22,032 deletions.
diff --git a/go/private/repositories.bzl b/go/private/repositories.bzl
@@ -64,13 +64,13 @@ def go_rules_dependencies(force = False):
     wrapper(
         http_archive,
         name = "org_golang_x_tools",
-        # v0.14.0, latest as of 2023-10-29
+        # v0.15.0, latest as of 2023-11-12
         urls = [
-            "https://mirror.bazel.build/github.com/golang/tools/archive/refs/tags/v0.14.0.zip",
-            "https://github.com/golang/tools/archive/refs/tags/v0.14.0.zip",
+            "https://mirror.bazel.build/github.com/golang/tools/archive/refs/tags/v0.15.0.zip",
+            "https://github.com/golang/tools/archive/refs/tags/v0.15.0.zip",
         ],
-        sha256 = "9c71911c61a791d8b13368ffbc409a0b38859cac80a4b5039487d2a27399e8b9",
-        strip_prefix = "tools-0.14.0",
+        sha256 = "e76a03b11719138502c7fef44d5e1dc4469f8c2fcb2ee4a1d96fb09aaea13362",
+        strip_prefix = "tools-0.15.0",
         patches = [
             # deletegopls removes the gopls subdirectory. It contains a nested
             # module with additional dependencies. It's not needed by rules_go.

diff --git a/go/tools/builders/nogo_main.go b/go/tools/builders/nogo_main.go
@@ -234,7 +234,7 @@ func checkPackage(analyzers []*analysis.Analyzer, packagePath string, packageFil
 
 	// Process diagnostics and encode facts for importers of this package.
 	diagnostics := checkAnalysisResults(roots, pkg)
-	facts := pkg.facts.Encode(true/* skipMethodSorting */)
+	facts := pkg.facts.Encode()
 	return diagnostics, facts, nil
 }
 
@@ -396,7 +396,7 @@ func load(packagePath string, imp *importer, filenames []string) (*goPackage, er
 	}
 	pkg.types, pkg.typesInfo = types, info
 
-	pkg.facts, err = facts.NewDecoder(pkg.types).Decode(true/* skipMethodSorting */, imp.readFacts)
+	pkg.facts, err = facts.NewDecoder(pkg.types).Decode(imp.readFacts)
 	if err != nil {
 		return nil, fmt.Errorf("internal error decoding facts: %v", err)
 	}

diff --git a/tests/integration/popular_repos/BUILD.bazel b/tests/integration/popular_repos/BUILD.bazel
@@ -186,7 +186,6 @@ test_suite(
         "@org_golang_x_tools//internal/event/export/ocagent:ocagent_test",
         "@org_golang_x_tools//internal/event/export/ocagent/wire:wire_test",
         "@org_golang_x_tools//internal/event/label:label_test",
-        "@org_golang_x_tools//internal/fastwalk:fastwalk_test",
         "@org_golang_x_tools//internal/fuzzy:fuzzy_test",
         "@org_golang_x_tools//internal/gopathwalk:gopathwalk_test",
         "@org_golang_x_tools//internal/jsonrpc2:jsonrpc2_test",

diff --git a/tests/integration/popular_repos/README.rst b/tests/integration/popular_repos/README.rst
@@ -184,7 +184,6 @@ This runs tests from the repository `golang.org/x/tools <https://golang.org/x/to
 * @org_golang_x_tools//internal/event/export/ocagent:ocagent_test
 * @org_golang_x_tools//internal/event/export/ocagent/wire:wire_test
 * @org_golang_x_tools//internal/event/label:label_test
-* @org_golang_x_tools//internal/fastwalk:fastwalk_test
 * @org_golang_x_tools//internal/fuzzy:fuzzy_test
 * @org_golang_x_tools//internal/gopathwalk:gopathwalk_test
 * @org_golang_x_tools//internal/jsonrpc2:jsonrpc2_test
@@ -232,5 +231,3 @@ This runs tests from the repository `golang.org/x/mod <https://golang.org/x/mod>
 * @org_golang_x_mod//sumdb/dirhash:dirhash_test
 * @org_golang_x_mod//sumdb/note:note_test
 * @org_golang_x_mod//sumdb/storage:storage_test
-
-