update erlang-client to have sync-create put timeout #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
feature/zl/timeout-for-search-index-create
branch
3 times, most recently
from
012ce62 to
9517ac8
Compare
zeeshanlakhani
force-pushed
the
feature/zl/timeout-for-search-index-create
branch
from
9517ac8 to
9284f7c
Compare
|
Needs a rebar.config tweak to use the 2.1.0.1 tag of riak_pb |
|
+1 bfc5623 |
|
Passes locally, see #204 (comment) |
borshop
added a commit
that referenced
this pull request
Mar 17, 2015
…x-create update erlang-client to have sync-create put timeout Reviewed-by: aberghage
zeeshanlakhani
force-pushed
the
feature/zl/timeout-for-search-index-create
branch
from
bfc5623 to
fbb7e26
Compare
| n_val = NVal} | ||
| }, | ||
| call_infinity(Pid, {req, Req, Timeout}). | ||
| Req = set_search_req_nval(NVal, Index, SchemaName), |
There was a problem hiding this comment.
This function is kind of badly named... you're not sending a search request, you're sending an "index creation" request.
* better naming of timeout/nval fns
zeeshanlakhani
force-pushed
the
feature/zl/timeout-for-search-index-create
branch
from
fbb7e26 to
fd20f92
Compare
|
Naming is much improved! |
|
Merging manually as per #204 (comment). |
zeeshanlakhani
added a commit
that referenced
this pull request
Mar 18, 2015
…x-create update erlang-client to have sync-create put timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to RIAK-1547 (#402)... in order for the erlang-client to allow for a user-given timeout (or default) for synchronously creating a search index. Relies on basho/riak_pb#112.