add get_preflist to erlang-client #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2015
Closed
This was referenced Feb 16, 2015
zeeshanlakhani
force-pushed
the
feature/zl/add-get-preflist
branch
from
e86e67d to
98a7d44
Compare
| @@ -68,6 +68,9 @@ | |||
| head | deletedvclock | | |||
| {n_val, pos_integer()} | | |||
| {sloppy_quorum, boolean()}. | |||
| -type preflist_item() :: {parition, non_neg_integer()} | {node, binary()} | | |||
There was a problem hiding this comment.
Typo: parition, I think you mean partition.
zeeshanlakhani
force-pushed
the
feature/zl/add-get-preflist
branch
from
98a7d44 to
244b608
Compare
|
This will need to update to use riak_pb tag |
|
@seancribbs makes sense. will do. |
|
👍 3a20f73 |
borshop
added a commit
that referenced
this pull request
Feb 27, 2015
add get_preflist to erlang-client Reviewed-by: seancribbs
|
These tests will not pass until we can get a proper version of Riak on the builders. Both @zeeshanlakhani and I have tested locally, merging manually. @zeeshanlakhani will tag after merge. |
seancribbs
pushed a commit
that referenced
this pull request
Feb 27, 2015
add get_preflist to erlang-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Bors will fail on this until a new version is referenced in rebar.config incorporating the update in basho/riak_pb#105 and the riak_core update is reviewed/merged.
Description
Part of RIAK-1481.
The active preflist will return primary/fallback partitions and nodes for the available nodes at the time of query. Primary/fallback will be annotated.
This involves updates to our RiakKV WB code, RiakPB, Riak-Erlang-Http-Client, Riak-Erlang-Client.
*The impetus for adding this to the API started with a mailing list question answered by Charlie Voiselle, http://lists.basho.com/pipermail/riak-users_lists.basho.com/2015-January/016527.html, which involved a snippet of code that we've given clients multiple times. This was then discussed with Russell Brown on HipChat, https://basho.hipchat.com/history/room/867200/2015/01/13?q=enterprising&t=rid-867200#12:23:22.
Other PRs in the series: